From: Masahiro Yamada <masahiroy@kernel.org>
To: Cherniaev Andrei <dungeonlords789@naver.com>
Cc: linux-kbuild@vger.kernel.org, yann.morin.1998@free.fr,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] kconfig: fix 'space' to (de)select options
Date: Tue, 24 Jun 2025 19:03:54 +0900 [thread overview]
Message-ID: <CAK7LNAQTUCQ4rdnwm-KMPoQxJMLF+HTFOvAM_uw15dG+HuBhhA@mail.gmail.com> (raw)
In-Reply-To: <20250621084124.7134-1-dungeonlords789@naver.com>
On Sat, Jun 21, 2025 at 5:51 PM Cherniaev Andrei
<dungeonlords789@naver.com> wrote:
>
> Fix that by treating 'space' as we treat y/m/n, ie. as an action key, not as shortcut to jump to prompt. This is copy of commit https://gitlab.com/buildroot.org/buildroot/-/raw/master/support/kconfig/patches/16-fix-space-to-de-select-options.patch
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
> ---
> scripts/kconfig/lxdialog/menubox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
> index 6e6244df0c56..d4c19b7beebb 100644
> --- a/scripts/kconfig/lxdialog/menubox.c
> +++ b/scripts/kconfig/lxdialog/menubox.c
> @@ -264,7 +264,7 @@ int dialog_menu(const char *title, const char *prompt,
> if (key < 256 && isalpha(key))
> key = tolower(key);
>
> - if (strchr("ynmh", key))
> + if (strchr("ynmh ", key))
> i = max_choice;
> else {
> for (i = choice + 1; i < max_choice; i++) {
> --
> 2.48.1
>
I will take directly from Buildroot (with your signed-off),
as this commit provides more details about how to reproduce the issue.
https://gitlab.com/buildroot.org/buildroot/-/commit/c6597e5aa3fa4bb52e9749797c90467083aa363b
Thanks
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2025-06-24 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 8:41 [PATCH 1/1] kconfig: fix 'space' to (de)select options Cherniaev Andrei
2025-06-24 10:03 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQTUCQ4rdnwm-KMPoQxJMLF+HTFOvAM_uw15dG+HuBhhA@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=dungeonlords789@naver.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).