From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67A1421660D for ; Tue, 1 Jul 2025 07:03:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751353394; cv=none; b=XiYULeXFjgoutLWjwBzx8sg3cLP5D1M2RiW+n5VR+ZUib56IBZPbOxsf3ohVKApnbZnvpRjHb20JhKvrCCwhmpA8iwIWGFUcKH7JKu/oUKUxqvF6orx7UjDC/bmvbOjujoq0BbY2YuSAaYIMSb7D0MpK5G358uIx0CL+mECX93c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751353394; c=relaxed/simple; bh=+EC0oMLVpnRfdUFzMGpfa0FgwGNFEt+oba3/joF/fnE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=pwsqd5ov5ikPAgB03SInHbRnlqSoYbhJNW5K9qnIV6cQMmm7QznGva2a64YC4qS1acdnbSl7mvG3ZIhmm4LQe2aCZnmQhZv8aSXZfE6B270rzwHJrgfvQn31NMzb+Z0OoCfAZgozFE6bsRy4gMi4pKZdfncgVbeJWS6Ye0FiKR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=HyIOv9Zg; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="HyIOv9Zg" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-553dceb342fso4784997e87.0 for ; Tue, 01 Jul 2025 00:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1751353390; x=1751958190; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iIU5NNrDBXiK6ci+KkmpULxlihLtb8DLKHWe5DIQOM0=; b=HyIOv9ZgCkwfijbz65r3487WW3wYSVV04iIhdLBXzt3HFvb/78AeXw2UAXTf0iDVUs IL/UBt10BtgGHAN0znmWoQuKBnLbr0d1oevRyil9rMw3Iu50MfpkPpnhnOewETmJsK/0 3DbULhAPhhFJcrKBZeo4b7j/yThflbjHmDox5PMUzx1mAdbo1+ouW1NXfNkDusqlcyXw xFtn4Z4Vi7ZwRgK2LY1igd+5t7H5SHCGI2gCOb+wqwQMJY1KQ9Z42rjzEocygsrjUL+m Mk8ZXX1KjeCjZ84BZBOZhFEtPNgDQKaPwTyXh8b4Ap+bL9jsAxKIz1M4UuhsAY9v2XKM Oh9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751353390; x=1751958190; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iIU5NNrDBXiK6ci+KkmpULxlihLtb8DLKHWe5DIQOM0=; b=kewOnyQhQ1vvZvCdmliKpK3YGaNMB8nAKxNKwQs78EW8uHMgldFMLDPeU6OYxh2b0D U/QyhF+1FGObHts2PP7L527AiXvRIXFsOW9f+O0itTV/8l3ask0VT8D+QV2ykcmtTTWL VU92VWwkeZnKIMs3S8VxoXa1i/onpPm5OparoskH8uwHMjszauRAJ2HSnvVlUgW0w7b8 DER4Go3EJTKnh0MepotXXUNt1LPnCbT0MfZ6xrA08IUTe4V/oxq8LzGtkiW/Yn3bDero Yv74Jcj/35NEN20AG0zA2bBXr8/r+TepHnUbitwjla2zBDdToTuUjf912mwO2SFYCk1M jxjQ== X-Forwarded-Encrypted: i=1; AJvYcCUj7kcTBsCLmc3L4MNu4WI2MwRLcPBVz9LAtigfjRr+hoc0lXCMg5MNfO4TTkqVzE8hRi9spjXa0bLe7nQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyESEjh+ucgUvYUr4MrFT0BKVXRs/8292NuIz0w+11jhOwMPT6B s4CV+vRK6C8Cj2lzgfvz2+vnSoGXyR7raznPD7dzn/WimoW788MnVDoUPK2GEHoNJMRw2DqFxnn 5H7aEw5mC7oapTyNMGNQTGUiUAEjCj5TmZPhoNpVGpA== X-Gm-Gg: ASbGnctbgDTYxU4pTKBq0vLcyBOMa+/6fRt8meWbSgMN+z/KC24nClto+o9751apWPS TEZ42fDigQl35838rj6rkw4y4F3Dgc6HvBuljSv91tGZNhWc8elhBfzlbbIH/Dyw3hKbeRJZm1u Ea1RZgV/KvvsAm0SbFdg82JArONRtJ/a3LwyuC9erwWCvcWebS19op7uw= X-Google-Smtp-Source: AGHT+IG2hO6nzI2GLaUpV//IQuh9V9bSS/bokBUiGKqfApG5Zg7ceEjqZCY0yleadUsPuqLCZd4pLgQndJnpi85hp6w= X-Received: by 2002:a05:6512:220d:b0:554:f76a:baaf with SMTP id 2adb3069b0e04-5550b9ee1c0mr5526546e87.56.1751353390315; Tue, 01 Jul 2025 00:03:10 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250618121358.503781-1-apatel@ventanamicro.com> <20250618121358.503781-7-apatel@ventanamicro.com> In-Reply-To: From: Anup Patel Date: Tue, 1 Jul 2025 12:32:57 +0530 X-Gm-Features: Ac12FXyj6dh_QMGxazJoimu3YO2qWqoVT9ukdJkMwkLRVDb7ZkWPIfUsIhiEvxA Message-ID: Subject: Re: [PATCH v6 06/23] mailbox: Add RISC-V SBI message proxy (MPXY) based mailbox driver To: Andy Shevchenko Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Thomas Gleixner , "Rafael J . Wysocki" , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Palmer Dabbelt , Paul Walmsley , Len Brown , Sunil V L , Rahul Pathak , Leyfoon Tan , Atish Patra , Andrew Jones , Samuel Holland , Anup Patel , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 23, 2025 at 2:20=E2=80=AFPM Andy Shevchenko wrote: > > On Wed, Jun 18, 2025 at 05:43:41PM +0530, Anup Patel wrote: > > Add a mailbox controller driver for the new SBI message proxy extension > > which is part of the SBI v3.0 specification. > > ... > > > +static void mpxy_mbox_remove(struct platform_device *pdev) > > +{ > > + struct mpxy_mbox *mbox =3D platform_get_drvdata(pdev); > > > + if (mbox->msi_count) > > I'm still not convinced we need this check _here_. > Can it be rather a separate patch to add it inside > the below call? IMHO, improving platform_device_msi_free_irqs_all() and its users should be a separate series. > > > + platform_device_msi_free_irqs_all(mbox->dev); > > +} > > ... > > > +static const struct of_device_id mpxy_mbox_of_match[] =3D { > > + {.compatible =3D "riscv,sbi-mpxy-mbox", }, > > Missing space and unneeded inner comma. Okay, I will update. > > > + {} > > +}; > > ... > > > --- a/include/linux/byteorder/generic.h > > +++ b/include/linux/byteorder/generic.h > > This is good change, but deserves to be in a separate patch. > I will Ack/Review it as soon as it appears to be so. > I generally prefer introduction and usage of a new API in the same patch since it provides better context. I don't mind creating separate patch so I will update in the next revision. Regards, Anup