From: Max Kellermann <max.kellermann@ionos.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: david@redhat.com, lorenzo.stoakes@oracle.com, ziy@nvidia.com,
baolin.wang@linux.alibaba.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, shikemeng@huaweicloud.com,
kasong@tencent.com, nphamcs@gmail.com, bhe@redhat.com,
chrisl@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] huge_mm.h: is_huge_zero_folio(NULL) should return false
Date: Wed, 27 Aug 2025 06:39:05 +0200 [thread overview]
Message-ID: <CAKPOu+9wz9g0VuYDPiNDYdaGG-gdK86h1gGSCmVPsC2a5f-GPA@mail.gmail.com> (raw)
In-Reply-To: <20250826185515.7fbe1821713195b170ac1b31@linux-foundation.org>
On Wed, Aug 27, 2025 at 3:55 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> Isn't it a bug to call is_huge_zero_folio() before the huge_zero_folio
> has been created?
I have no idea, but folios_put_refs() calls it and I don't see why it
shouldn't be allowed to do that. What else should folios_put_refs()
do?
(Thanks Zi Yan, I'll send v2 with your suggestions.)
next prev parent reply other threads:[~2025-08-27 4:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 23:16 [PATCH 1/2] huge_mm.h: is_huge_zero_folio(NULL) should return false Max Kellermann
2025-08-26 23:16 ` [PATCH 2/2] mm/swap: add BUG_ON(folio==NULL) to folios_put_refs() Max Kellermann
2025-08-27 1:42 ` Zi Yan
2025-08-27 2:12 ` Chris Li
2025-08-27 9:38 ` David Hildenbrand
2025-08-27 1:19 ` [PATCH 1/2] huge_mm.h: is_huge_zero_folio(NULL) should return false Zi Yan
2025-08-27 1:55 ` Andrew Morton
2025-08-27 4:39 ` Max Kellermann [this message]
2025-08-27 9:36 ` David Hildenbrand
2025-08-27 10:13 ` Max Kellermann
2025-08-27 11:56 ` David Hildenbrand
2025-08-27 13:06 ` Max Kellermann
2025-08-27 14:34 ` David Hildenbrand
2025-08-27 15:03 ` [PATCH v2] huge_mm.h: disallow is_huge_zero_folio(NULL) Max Kellermann
2025-08-27 15:16 ` Lorenzo Stoakes
2025-08-27 15:38 ` Max Kellermann
2025-08-27 20:01 ` David Hildenbrand
2025-08-27 20:26 ` David Hildenbrand
2025-08-27 20:44 ` Lorenzo Stoakes
2025-08-28 8:48 ` [PATCH v3] " Max Kellermann
2025-08-28 9:35 ` Lorenzo Stoakes
2025-08-29 1:25 ` Zi Yan
2025-08-27 23:53 ` [PATCH v2] " Andrew Morton
2025-08-28 5:17 ` Max Kellermann
2025-08-28 7:57 ` David Hildenbrand
2025-08-27 15:05 ` [PATCH 1/2] huge_mm.h: is_huge_zero_folio(NULL) should return false Max Kellermann
2025-08-27 9:35 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKPOu+9wz9g0VuYDPiNDYdaGG-gdK86h1gGSCmVPsC2a5f-GPA@mail.gmail.com \
--to=max.kellermann@ionos.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=npache@redhat.com \
--cc=nphamcs@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).