* [PATCH] fat: use accessor function for msdos_dir_entry 'start'
@ 2012-08-12 3:56 Namjae Jeon
2012-08-12 4:05 ` OGAWA Hirofumi
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2012-08-12 3:56 UTC (permalink / raw)
To: hirofumi, akpm; +Cc: linux-kernel, Namjae Jeon, Amit Sahrawat
Use accessor function for msdos_dir_entry 'start'
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
---
fs/fat/dir.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 7b1b9c1..2f3e66e 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -1143,10 +1143,8 @@ int fat_alloc_new_dir(struct inode *dir, struct timespec *ts)
de[0].ctime_cs = de[1].ctime_cs = 0;
de[0].adate = de[0].cdate = de[1].adate = de[1].cdate = 0;
}
- de[0].start = cpu_to_le16(cluster);
- de[0].starthi = cpu_to_le16(cluster >> 16);
- de[1].start = cpu_to_le16(MSDOS_I(dir)->i_logstart);
- de[1].starthi = cpu_to_le16(MSDOS_I(dir)->i_logstart >> 16);
+ fat_set_start(&de[0], cluster);
+ fat_set_start(&de[1], MSDOS_I(dir)->i_logstart);
de[0].size = de[1].size = 0;
memset(de + 2, 0, sb->s_blocksize - 2 * sizeof(*de));
set_buffer_uptodate(bhs[0]);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fat: use accessor function for msdos_dir_entry 'start'
2012-08-12 3:56 [PATCH] fat: use accessor function for msdos_dir_entry 'start' Namjae Jeon
@ 2012-08-12 4:05 ` OGAWA Hirofumi
2012-08-18 9:54 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: OGAWA Hirofumi @ 2012-08-12 4:05 UTC (permalink / raw)
To: Namjae Jeon; +Cc: akpm, linux-kernel, Amit Sahrawat
Namjae Jeon <linkinjeon@gmail.com> writes:
> Use accessor function for msdos_dir_entry 'start'
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Looks good. Thanks.
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
> ---
> fs/fat/dir.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index 7b1b9c1..2f3e66e 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -1143,10 +1143,8 @@ int fat_alloc_new_dir(struct inode *dir, struct timespec *ts)
> de[0].ctime_cs = de[1].ctime_cs = 0;
> de[0].adate = de[0].cdate = de[1].adate = de[1].cdate = 0;
> }
> - de[0].start = cpu_to_le16(cluster);
> - de[0].starthi = cpu_to_le16(cluster >> 16);
> - de[1].start = cpu_to_le16(MSDOS_I(dir)->i_logstart);
> - de[1].starthi = cpu_to_le16(MSDOS_I(dir)->i_logstart >> 16);
> + fat_set_start(&de[0], cluster);
> + fat_set_start(&de[1], MSDOS_I(dir)->i_logstart);
> de[0].size = de[1].size = 0;
> memset(de + 2, 0, sb->s_blocksize - 2 * sizeof(*de));
> set_buffer_uptodate(bhs[0]);
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fat: use accessor function for msdos_dir_entry 'start'
2012-08-12 4:05 ` OGAWA Hirofumi
@ 2012-08-18 9:54 ` Namjae Jeon
0 siblings, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2012-08-18 9:54 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Amit Sahrawat, OGAWA Hirofumi
2012/8/12, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> Use accessor function for msdos_dir_entry 'start'
>
> Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
> Looks good. Thanks.
>
>> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
>> Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
>> ---
>> fs/fat/dir.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
>> index 7b1b9c1..2f3e66e 100644
>> --- a/fs/fat/dir.c
>> +++ b/fs/fat/dir.c
>> @@ -1143,10 +1143,8 @@ int fat_alloc_new_dir(struct inode *dir, struct
>> timespec *ts)
>> de[0].ctime_cs = de[1].ctime_cs = 0;
>> de[0].adate = de[0].cdate = de[1].adate = de[1].cdate = 0;
>> }
>> - de[0].start = cpu_to_le16(cluster);
>> - de[0].starthi = cpu_to_le16(cluster >> 16);
>> - de[1].start = cpu_to_le16(MSDOS_I(dir)->i_logstart);
>> - de[1].starthi = cpu_to_le16(MSDOS_I(dir)->i_logstart >> 16);
>> + fat_set_start(&de[0], cluster);
>> + fat_set_start(&de[1], MSDOS_I(dir)->i_logstart);
>> de[0].size = de[1].size = 0;
>> memset(de + 2, 0, sb->s_blocksize - 2 * sizeof(*de));
>> set_buffer_uptodate(bhs[0]);
>
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
Hi. Andrew.
Would you plz check this patch ?
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-18 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-12 3:56 [PATCH] fat: use accessor function for msdos_dir_entry 'start' Namjae Jeon
2012-08-12 4:05 ` OGAWA Hirofumi
2012-08-18 9:54 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).