linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kristian Evensen <kristian.evensen@gmail.com>
To: Lars Melin <larsm17@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] option: Improve Quectel EP06 detection
Date: Tue, 11 Sep 2018 16:34:18 +0200	[thread overview]
Message-ID: <CAKfDRXgTL6L27JLbbOLLsXd9KK8vBtVCjrTNpv6R_MYCJoZqPg@mail.gmail.com> (raw)
In-Reply-To: <8ce10eef-f332-a1c0-e16e-fb1c2055131a@gmail.com>

On Tue, Sep 11, 2018 at 4:00 PM Lars Melin <larsm17@gmail.com> wrote:
> This also becomes a mess for the qmi-wwan driver which has the rmnet/qmi
> interface hardcoded to 4 so that driver will also need a workaround.
> Quectel seems to have completely missed the reason why usb id's should
> be unique and not reused  for a different product or a different
> interface layout, there is already a workaround in qmi-wwan for their
> previous EC-20 card...

A patch has already been submitted to work around the issue in qmi driver.

> My opinion is that the option and qmi-wwan drivers should support EP06
> in the factory delivery configuration and not in a configuration the
> user has selected with a Quectel proprietary AT cmd.
> Can you give some good reason for disabling an interface instead of
> letting it stay but not use it if you don't need it?

Yes. I am working with two boards, one based on MT7621 and the other
on MT7623, and I would like to connect two EP06-modems to these
boards. However, the USB-controller used on these SoCs has a (very)
limited number of USB endpoints. With the default configuration, there
are only enough endpoints for one EP06-modem to work properly. By
disabling diag, there are enough endpoints for both modems to work
correctly.

BR,
Kristian

  reply	other threads:[~2018-09-11 14:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-08 12:57 [PATCH] option: Improve Quectel EP06 detection Kristian Evensen
2018-09-10 10:30 ` Johan Hovold
2018-09-10 11:39   ` Kristian Evensen
2018-09-11 14:00     ` Lars Melin
2018-09-11 14:34       ` Kristian Evensen [this message]
2018-09-12 16:32         ` Lars Melin
2018-09-12 16:57           ` Kristian Evensen
2018-09-12 18:25             ` Lars Melin
2018-09-12 19:18               ` Dan Williams
2018-09-12 20:34                 ` Bjørn Mork
2018-09-13  9:17                   ` Johan Hovold
2018-09-13  9:21                     ` [PATCH 1/2] USB: serial: option: improve " Johan Hovold
2018-09-13  9:21                       ` [PATCH 2/2] USB: serial: option: add two-endpoints device-id flag Johan Hovold
2018-09-13  9:44                     ` [PATCH] option: Improve Quectel EP06 detection Kristian Evensen
2018-09-13 15:13                     ` Kristian Evensen
2018-09-14  7:51                       ` Johan Hovold
2018-09-14  7:53                         ` Kristian Evensen
2018-09-14  8:42                           ` Johan Hovold
2018-09-10 14:43 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKfDRXgTL6L27JLbbOLLsXd9KK8vBtVCjrTNpv6R_MYCJoZqPg@mail.gmail.com \
    --to=kristian.evensen@gmail.com \
    --cc=johan@kernel.org \
    --cc=larsm17@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).