From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbbCXVmQ (ORCPT ); Tue, 24 Mar 2015 17:42:16 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:38809 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751876AbbCXVmO (ORCPT ); Tue, 24 Mar 2015 17:42:14 -0400 MIME-Version: 1.0 In-Reply-To: <20150320002949.72d2d141@linux.lan.towertech.it> References: <1421770899-4136-1-git-send-email-pang.xunlei@linaro.org> <20150128192700.15269823@linux.lan.towertech.it> <20150320002949.72d2d141@linux.lan.towertech.it> Date: Tue, 24 Mar 2015 14:42:14 -0700 Message-ID: Subject: Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64() From: John Stultz To: Alessandro Zummo Cc: Xunlei Pang , lkml , "rtc-linux@googlegroups.com" , Thomas Gleixner , Richard Henderson , Uwe Kleine-Koenig , Linus Walleij , Fabio Estevam , Arnd Bergmann , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 19, 2015 at 4:29 PM, Alessandro Zummo wrote: > On Wed, 18 Mar 2015 10:37:26 -0700 > John Stultz wrote: > >> On Wed, Jan 28, 2015 at 10:27 AM, Alessandro Zummo wrote: >> > On Thu, 29 Jan 2015 00:12:09 +0800 >> > Xunlei Pang wrote: >> > >> >> ping Alessandro >> > >> > -EBUSY . saw that, looks fine anyhow, but would like to >> > have a deeper look. we have still some time 'till 2038, right? ;) >> >> Hey Alessandro, >> I was hoping to let these go through you (with your review), but if >> you're still too busy I can queue them if you'd rather. > > Looks fine to me. The only thing that I would change > is the naming of the drivername_rtc_set_mmss in the drivers: > it should end with mmss64 when it's changed. > > But that's probably just me being pedantic. > > Acked-by: Alessandro Zummo > > Can you please queue them? Thanks for the review! I've queued them in my tree for 4.1 thanks -john