From: Ujwal Kundur <ujwal.kundur@gmail.com>
To: Brendan Jackman <jackmanb@google.com>
Cc: akpm@linux-foundation.org, peterx@redhat.com, shuah@kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct
Date: Sat, 3 May 2025 23:46:26 +0530 [thread overview]
Message-ID: <CALkFLLJ4CYRFuyR8sHi5Ah06QD_fDuF9v5eCyG7Xh+2kHPVzEg@mail.gmail.com> (raw)
In-Reply-To: <CA+i-1C1x2TenH-WxkUnkx3-5XpkXOMMmZQTCBV3sHDV8WWN=oA@mail.gmail.com>
Thanks for the review and testing!
I'll push a V2 with the indentation fixes soon.
> this deletes the global vars before it deletes
> the references to them. That's gonna be a real pain for bisections,
> please can you restructure the series to prevent intervening build
> failures?
> (i.e. if I apply just 1/4, the selftests don't compile).
Could you help me understand this better? The selftests don't compile
either way if both 1 and 2/3/4 aren't applied at the same time.
--- Ujwal.
next prev parent reply other threads:[~2025-05-03 18:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 16:38 [PATCH 0/4] selftests/mm/uffd: refactor global variables Ujwal Kundur
2025-05-01 16:38 ` [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct Ujwal Kundur
2025-05-02 12:16 ` Brendan Jackman
2025-05-02 12:28 ` Brendan Jackman
2025-05-03 18:16 ` Ujwal Kundur [this message]
2025-05-04 2:25 ` Andrew Morton
2025-05-01 16:38 ` [PATCH 2/4] selftests/mm/uffd: Swap global vars with global test options Ujwal Kundur
2025-05-01 16:38 ` [PATCH 3/4] selftests/mm/uffd: Swap global variables with global test opts Ujwal Kundur
2025-05-01 16:38 ` [PATCH 4/4] " Ujwal Kundur
2025-05-02 12:18 ` [PATCH 0/4] selftests/mm/uffd: refactor global variables Brendan Jackman
2025-05-04 9:48 ` [PATCH v2 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct Ujwal Kundur
2025-05-06 0:57 ` Andrew Morton
2025-05-10 16:03 ` [PATCH v3 " Ujwal Kundur
2025-05-13 12:12 ` Brendan Jackman
2025-05-19 13:50 ` Ujwal Kundur
2025-05-19 21:40 ` Andrew Morton
2025-05-20 9:16 ` Brendan Jackman
2025-05-25 19:19 ` Ujwal Kundur
2025-05-26 9:08 ` Brendan Jackman
2025-05-30 7:45 ` Ujwal Kundur
2025-05-31 7:46 ` [PATCH v4 " Ujwal Kundur
2025-06-10 6:57 ` Ujwal Kundur
2025-06-10 11:32 ` Brendan Jackman
2025-06-16 6:38 ` Ujwal Kundur
2025-06-16 10:04 ` [PATCH v5 " Ujwal Kundur
2025-06-17 0:26 ` Andrew Morton
2025-06-17 15:52 ` Peter Xu
2025-06-17 17:22 ` Peter Xu
2025-06-18 10:00 ` Brendan Jackman
2025-06-26 5:22 ` Ujwal Kundur
2025-06-26 14:12 ` Peter Xu
2025-06-30 11:25 ` Ujwal Kundur
2025-07-02 15:20 ` [PATCH v6 " Ujwal Kundur
2025-07-04 16:20 ` Peter Xu
2025-07-10 5:07 ` Ujwal Kundur
2025-08-06 15:03 ` Ujwal Kundur
2025-08-07 16:45 ` Peter Xu
2025-08-13 11:33 ` Brendan Jackman
2025-08-16 14:12 ` Ujwal Kundur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALkFLLJ4CYRFuyR8sHi5Ah06QD_fDuF9v5eCyG7Xh+2kHPVzEg@mail.gmail.com \
--to=ujwal.kundur@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).