From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 652BD19F101 for ; Wed, 20 Nov 2024 11:06:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732100818; cv=none; b=IvfcudsUoWFUs/DGWYrJ9A799Kl6f0MG9PmhbIMDWrviE5PYzNYxF2YTHcWu4eAg/WERZD+sbR2qkPZn50qIVQGptS0YLT1CQLgMXnmk1x8bFG7QAgO/1CWU/MRE4GjAmRlMLEBbseCJUmYyK5S4/tUg2E4BrZEKIc3iLph3D24= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732100818; c=relaxed/simple; bh=E1fMywgxDcHRktEbljCMO94I8Q/I8jzTUKls+5BAhJE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=JJegeNEw7AsFOa5lmrEmLNkdV9MdaD1COaHP5LnWyEJvcWiyziNMeAT/brT4aHD0ZEjpgn+BraxFaLXH77BQKayTwnSufA+DmAgbuIOYOJ5svxTp5dhSYWCyiOM+XDPeNuG0bDrRCE8WAyoUWBFA/E/w0ZVWedvMES4Lq6aLTuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lj9YPvUn; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lj9YPvUn" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-539e59dadebso2615992e87.0 for ; Wed, 20 Nov 2024 03:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1732100814; x=1732705614; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0a2Q1YpX3f2jZn2lmKVw7Bna28DOeMJLfMK/S0CPYlw=; b=lj9YPvUn05IVyLaRmn4dTDNIJteFggyRpj0lgo7m1P8q0XM2dmqemTP3q+vdjO17/y QRq/BbIgNoMwuV5rfzlujhzhF6CKo7kpyqhGKhdYRyyFIcPPTdrJEptbChfBpRd0QLvO Y6aeo5878e0nxb6ZwPMDXdob4eAr+i1RS4qj9pLk5BCVYbjXNX80IDe4e/JRhWV3vaqj jgR5YRgMt8NVfAYE8QP/qRRA/rFFAPP6PVy+FBR7YGnHOavNU0i87MfqRjPoFWox5TXA xvaHklBb2vMv+0nTkCkqMF5tPiINZRWbI4/2HVmyyl5P3x8SKw3gUw1vekXMge8ysqEw 7B2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732100814; x=1732705614; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0a2Q1YpX3f2jZn2lmKVw7Bna28DOeMJLfMK/S0CPYlw=; b=AV8BYkhTejbDliaciQudl90Jvvx0nc571nvOCXlpiJ4rx9hbcVXtAj0g4aWxgGdUiN PywVHV6sYDTf7FTSn9VIOBK911Ogoj1sq1E0SjnkVWPrS9avB6L8RFE9Hg46Mnb/bIIy VyUgJCfagJKII0X1oYd09kg55y8GdmqdLKCAD1OUQz/snxiHB12THLcnb0+NJ2hJ+iZG KJGbjxmUeM0nYd6l3Mrfr7nkBsqBww1YW/0XIP41In+UWNuov72SHFwC+C5d7ymHhRQb AkyxNHvpdApJ1yW0+yFwq5i8tFUSvkoE8jeU5z5VjewmOCsQvcXzuPgr2roUhGtHihdh dAiA== X-Forwarded-Encrypted: i=1; AJvYcCWhhd5OyTj65iwwBE0MigTaj9waKW29echHHi9OfveMOgNrsg64NNw0naOQasY14kVU6qmdze7fl6+qQNU=@vger.kernel.org X-Gm-Message-State: AOJu0YzgiphvmSsN2a8R6AeZt+RRmElvnRacTGIV/WR0JIjzB5og91bH h24gQvn9cTYS2AKMN/Mau+KmKXOd1Ad/Evgi5uaexxs8uHnAH2t8HGS6eL5I3hntY+w0KKX1rXm w9FpqhQcFdx2bjCvcmEcZQ8Vo4VsqtIIElS0k+w== X-Gm-Gg: ASbGncttZyWNKnEq8A909QDeFPuqkuaxzJ7lW5xQiCjHYYEh4Gl/FgYXm9wB51Hmm0l tHgVAoyx+W0MQE6LaZ3LzHvK9T+egvLk6+/MuOWixpsANddORXalXr5WFpT3qH4s= X-Google-Smtp-Source: AGHT+IE/x949hrTGW5Uqy8CIyatEY/kXsSYucKCpBxkcG1D4ERCx0WrgFXmLbfvQh49sIz3CfwXECwr/RgGqRvj1Xag= X-Received: by 2002:a05:6512:4012:b0:539:e97c:cb10 with SMTP id 2adb3069b0e04-53dc136cfaamr867566e87.40.1732100814608; Wed, 20 Nov 2024 03:06:54 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241119-qcom-scm-missing-barriers-and-all-sort-of-srap-v1-0-7056127007a7@linaro.org> <20241119-qcom-scm-missing-barriers-and-all-sort-of-srap-v1-6-7056127007a7@linaro.org> In-Reply-To: <20241119-qcom-scm-missing-barriers-and-all-sort-of-srap-v1-6-7056127007a7@linaro.org> From: Bartosz Golaszewski Date: Wed, 20 Nov 2024 12:06:43 +0100 Message-ID: Subject: Re: [PATCH 6/6] firmware: qcom: scm: smc: Narrow 'mempool' variable scope To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Mukesh Ojha , Dmitry Baryshkov , Stephan Gerhold , Bartosz Golaszewski , Kuldeep Singh , Elliot Berman , Andrew Halaney , Avaneesh Kumar Dwivedi , Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 19, 2024 at 7:38=E2=80=AFPM Krzysztof Kozlowski wrote: > > Only part of the __scm_smc_call() function uses 'mempool' variable, so > narrow the scope to make it more readable. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/firmware/qcom/qcom_scm-smc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/qcom/qcom_scm-smc.c b/drivers/firmware/qcom= /qcom_scm-smc.c > index 3f10b23ec941b558e1d91761011776bb5c9d11b5..574930729ddd72d98013770da= 97cc018a52554ff 100644 > --- a/drivers/firmware/qcom/qcom_scm-smc.c > +++ b/drivers/firmware/qcom/qcom_scm-smc.c > @@ -152,7 +152,6 @@ int __scm_smc_call(struct device *dev, const struct q= com_scm_desc *desc, > enum qcom_scm_convention qcom_convention, > struct qcom_scm_res *res, bool atomic) > { > - struct qcom_tzmem_pool *mempool =3D qcom_scm_get_tzmem_pool(); > int arglen =3D desc->arginfo & 0xf; > int i, ret; > void *args_virt __free(qcom_tzmem) =3D NULL; > @@ -173,6 +172,8 @@ int __scm_smc_call(struct device *dev, const struct q= com_scm_desc *desc, > smc.args[i + SCM_SMC_FIRST_REG_IDX] =3D desc->args[i]; > > if (unlikely(arglen > SCM_SMC_N_REG_ARGS)) { > + struct qcom_tzmem_pool *mempool =3D qcom_scm_get_tzmem_po= ol(); > + > if (!mempool) > return -EINVAL; > > > -- > 2.43.0 > > Reviewed-by: Bartosz Golaszewski