From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570782765DC for ; Mon, 1 Sep 2025 13:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756732859; cv=none; b=a7V0tUbbUKyxjW13x7kMqm3/YIPn2ZEFcARS3/fWDLVXB4bfTfETmP4Snp9iA4rhJILOim3C9j7Ijid+g43lD18Gizg71IYW49YRmXRvLLqJ1+hG6QAMPbRbx1X1fe+FktetvStkcIl/F0OekVGJ4qD1RR78KhwN6f1pW/dbJ6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756732859; c=relaxed/simple; bh=+FzHD6P3GIG+WbvurBqu4eNuHXM1ihNGPdVL0Rl46EY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=PYr0+VPU+G37r+xMs7ArdU1X3b43c2KOipxEcSrxqqua5THUwzOAyIob0dWFXElKe7lwEcMDrf0jKkjwY1LeI+XOXLemICrlLTIudEFzq2xLP4i3zZoMbiNdhdOopcqbKdPuHEFeSRFLnccWpkJcilALgdVFfMPWjndKo5yUkiA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=NXqh/pNg; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="NXqh/pNg" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-55f7ab2a84eso1089910e87.1 for ; Mon, 01 Sep 2025 06:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756732855; x=1757337655; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/ApJifxHePLgmXB9tTWAWedH0XfL5fOO8paxsOA3xkw=; b=NXqh/pNgFvdh9534gdG5el6/ZagbcM4qdqFZr+bWDTOqlYOI7PzxLWNJpKAk0Jgw1o s0tv+sMZ1fZfMi3cl0T8CdMrzwyvldKPomK1W+l9cLLBhtRBFqMYxk+MIhqu352PH1FT PBoChcd91xX7UCHGjfj9JfHSxJGjH+w1vA2E39gFTUVFDLhItLGeT/Pfj5lTzSy+u+L+ OZz2VDGzuqaMeTUlrGP0aZEP6BDnjizjkuyz4hPpPspV1+PUkkfcCcSBLyrjgJDaT80r /+xEWKIfUPKJMg4uwzkVzJBqSKLL4VEHXvCwu4IaATXnNwATlNbZ01/S335v8zUvalv5 AMYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756732855; x=1757337655; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/ApJifxHePLgmXB9tTWAWedH0XfL5fOO8paxsOA3xkw=; b=KD59GpwSz8ZALt5JvBfn2gYivLG6DY7+5FfIvFNYprXaXeLc1DCAUfgtsDIOaDHccN HM4Aabp5K1Wx/zZ/s4Qq5c0jR2r2NNF5koqFLBS3ApYt53OghFmOd0gso8tPtzP3NdDf KMnT1YYTHn3e9v74qwsAVHC0+4QR9Ku8cwMYO2G8+B/vxd8X2jDxRbua+MPMxvBUjCsS ovDgpHvX/1gxmJ7HgmgSGVw+FpBV+PMBfV6i0rRjicB+1Z9OGisJ7/1iQEiWAn7Z8yTP dj1IG0cIlSFRTMhgt9BqXlbLG+rGf8h/9GclRRlX46HQ73P+MhzYrr6v1hZC/ncoPoKx gwuA== X-Forwarded-Encrypted: i=1; AJvYcCUL4dM9U72pLAWgoAgri1liSkayYNu1J0Zbb8XNs9cmwqB2TZRKB7TcuT+oXhvmkbSErbmn6mrR9zhMPBI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2fnX1ugSimc2TfepEyuyv60Z09/4aKmL/AtBRZX2gKyclfEE+ ALOt0SG5RP1xEFUh12ItdJe28x+rH9pZhAlRWR6cPBlzw9st9oM/mf6Uxz0/rk/k2LdaRXBLrFh EGdpo9qfeXHrRMUBFD4A+61gSX4PW/LQn6KGsUtHjTQ== X-Gm-Gg: ASbGncuzkjS28xa2J8cL3zqM2mojeh622ljBid22MYzlU0p18zpxYdCcEuwlk6jjXZp 5UTueadkZG/9NpQCMVbbInn5vqlNU69zKftx8wiZ1tzGoAfHIkap5URPzH7O4XUWy4O4oauz8P5 P3RPKDhX8E2XBrhNyvdXP4/sbNEopVTr6rMQWNThruymp0Cx6V0nN6+VbuVXxCwZSYUnjHsBIbn WnwSVEp1o0MJhBinaxms1lIEA9MauDGjC+8+cE= X-Google-Smtp-Source: AGHT+IH912XrSXzjBk2qT9512Zc2BnDvh2hCyUh1tIL/e/b5XAWzm9U6VOUb2k8kMnjWcaLf9C4w4UWLuNtsABXzYyY= X-Received: by 2002:a05:6512:2513:b0:55f:4016:ad2b with SMTP id 2adb3069b0e04-55f708eae52mr2361617e87.30.1756732855435; Mon, 01 Sep 2025 06:20:55 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250828-pinctrl-gpio-pinfuncs-v6-0-c9abb6bdb689@linaro.org> <20250828-pinctrl-gpio-pinfuncs-v6-6-c9abb6bdb689@linaro.org> <61bad868-d976-4f49-805c-8d14d4d8b3e4@sirena.org.uk> In-Reply-To: <61bad868-d976-4f49-805c-8d14d4d8b3e4@sirena.org.uk> From: Bartosz Golaszewski Date: Mon, 1 Sep 2025 15:20:44 +0200 X-Gm-Features: Ac12FXxw4k3UY5TBARAefSnKyhMDuDCBaUNs2qyNKYW8yrbkHP8etuyQPhIAuGM Message-ID: Subject: Re: [PATCH v6 06/15] pinctrl: imx: don't access the pin function radix tree directly To: Mark Brown Cc: Linus Walleij , Bjorn Andersson , Konrad Dybcio , Alexey Klimov , Lorenzo Bianconi , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Paul Cercueil , Kees Cook , Andy Shevchenko , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , NXP S32 Linux Team , Sascha Hauer , Tony Lindgren , Haojian Zhuang , Geert Uytterhoeven , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Neil Armstrong , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 1, 2025 at 2:07=E2=80=AFPM Mark Brown wrot= e: > > On Thu, Aug 28, 2025 at 06:00:14PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The radix tree containing pin function descriptors should not be > > accessed directly by drivers. There are dedicated functions for it. I > > suppose this driver does it so that the memory containing the function > > description is not duplicated but we're going to address that shortly s= o > > convert it to using generic pinctrl APIs. > > This is still failing for me: > > [ 0.628221] Unable to handle kernel NULL pointer dereference at virtua= l address 0000000000000000 > [ 0.636506] Mem abort info: > > ... > > [ 0.801855] __pi_strcmp+0x20/0x140 (P) > [ 0.805704] pinmux_generic_add_pinfunction+0x28/0xe0 > [ 0.810777] imx_pinctrl_parse_functions.isra.0+0xf8/0x4a0 > [ 0.816289] imx_pinctrl_probe+0x404/0x520 > > Full log: > > https://lava.sirena.org.uk/scheduler/job/1758025#L704 That's not a lot of info but it fails in strcmp() which - I suppose - is the one in pinmux_func_name_to_selector(). Any chance you could check what the value of np->name is in imx_pinctrl_parse_functions()? Is it NULL for some reason? Bart