From: Colin Cross <ccross@android.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Bryan Wu <bryan.wu@canonical.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: triggers: send uevent when changing triggers
Date: Tue, 7 Aug 2012 12:44:02 -0700 [thread overview]
Message-ID: <CAMbhsRT8U5rDuSQQ3_d44LsOUivyGviqMBOLV+Xpe7==90FGQw@mail.gmail.com> (raw)
In-Reply-To: <20120807143656.GA22791@khazad-dum.debian.net>
On Tue, Aug 7, 2012 at 7:36 AM, Henrique de Moraes Holschuh
<hmh@hmh.eng.br> wrote:
> On Tue, 07 Aug 2012, Bryan Wu wrote:
<snip>
>> Greg, Richard and Henrique, can I take you guys' Ack here?
>
> Yes, you have my Acked-by, provided that the uevent is NOT sent before
> the led is fully registered (I cannot check right now if the patch does
> this right or not. I apologise in advance if this was an unecessary
> question).
>
> I don't care whether the uevent gets sent right after registration, or
> only when the trigger *changes* after registering. But someone might,
> so it would be nice to document this.
>
> Considering Greg's answer, maybe it would be best to resend the patch
> with the point above clarified in the commit message or in the in-tree
> documentation of the LED class?
led_trigger_set_default is called last from led_classdev_register, so
it will send a uevent during registration but after it is fully
registered. I will resend the patch with the clarification.
prev parent reply other threads:[~2012-08-07 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 0:32 [PATCH] leds: triggers: send uevent when changing triggers Colin Cross
2012-07-25 6:11 ` Bryan Wu
2012-07-25 14:36 ` Greg KH
2012-07-25 18:54 ` Colin Cross
2012-07-26 3:29 ` Bryan Wu
2012-07-26 3:59 ` Greg KH
2012-07-26 5:03 ` Bryan Wu
2012-07-26 16:51 ` Greg KH
2012-07-27 4:04 ` Bryan Wu
2012-07-31 18:28 ` Colin Cross
2012-08-07 2:57 ` Bryan Wu
2012-08-07 3:34 ` Greg KH
[not found] ` <CAK5ve-KLdwEqW6MLbusMRkaHBQkxTqOGLoVWzSmiuo2qxwtwmA@mail.gmail.com>
2012-08-07 3:43 ` Greg KH
2012-08-07 14:36 ` Henrique de Moraes Holschuh
2012-08-07 19:44 ` Colin Cross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMbhsRT8U5rDuSQQ3_d44LsOUivyGviqMBOLV+Xpe7==90FGQw@mail.gmail.com' \
--to=ccross@android.com \
--cc=bryan.wu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).