[PATCH] arch: m68k: mvme147: config.c: Remove unused function

[PATCH] arch: m68k: mvme147: config.c: Remove unused function

[Rickard Strandqvist]

Remove the function mvme147_init_console_port() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 arch/m68k/mvme147/config.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c
index 1bb3ce6..5da5e6e 100644
--- a/arch/m68k/mvme147/config.c
+++ b/arch/m68k/mvme147/config.c
@@ -209,8 +209,3 @@ void m147_scc_write (struct console *co, const char *str, unsigned count)
 	}
 	local_irq_restore(flags);
 }
-
-void mvme147_init_console_port (struct console *co, int cflag)
-{
-	co->write    = m147_scc_write;
-}
-- 
1.7.10.4

Re: [PATCH] arch: m68k: mvme147: config.c: Remove unused function

[Geert Uytterhoeven]

On Thu, Jan 1, 2015 at 5:49 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Remove the function mvme147_init_console_port() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>  arch/m68k/mvme147/config.c |    5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c
> index 1bb3ce6..5da5e6e 100644
> --- a/arch/m68k/mvme147/config.c
> +++ b/arch/m68k/mvme147/config.c
> @@ -209,8 +209,3 @@ void m147_scc_write (struct console *co, const char *str, unsigned count)
>         }
>         local_irq_restore(flags);
>  }
> -
> -void mvme147_init_console_port (struct console *co, int cflag)
> -{
> -       co->write    = m147_scc_write;
> -}

And after that m147_scc_write() becomes unused, and scc_write(), and
scc_delay()... I will remove these, too.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] arch: m68k: mvme147: config.c: Remove unused function

[Geert Uytterhoeven]

On Mon, Jan 5, 2015 at 12:39 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Jan 1, 2015 at 5:49 PM, Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se> wrote:
>> Remove the function mvme147_init_console_port() that is not used anywhere.
>>
>> This was partially found by using a static code analysis program called cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>> ---
>>  arch/m68k/mvme147/config.c |    5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c
>> index 1bb3ce6..5da5e6e 100644
>> --- a/arch/m68k/mvme147/config.c
>> +++ b/arch/m68k/mvme147/config.c
>> @@ -209,8 +209,3 @@ void m147_scc_write (struct console *co, const char *str, unsigned count)
>>         }
>>         local_irq_restore(flags);
>>  }
>> -
>> -void mvme147_init_console_port (struct console *co, int cflag)
>> -{
>> -       co->write    = m147_scc_write;
>> -}
>
> And after that m147_scc_write() becomes unused, and scc_write(), and
> scc_delay()... I will remove these, too.

Thanks, applied and queued for 3.20.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds