From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751886AbbAKKnD (ORCPT ); Sun, 11 Jan 2015 05:43:03 -0500 Received: from mail-lb0-f177.google.com ([209.85.217.177]:34678 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813AbbAKKm7 (ORCPT ); Sun, 11 Jan 2015 05:42:59 -0500 MIME-Version: 1.0 In-Reply-To: References: <1420130951-29766-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Date: Sun, 11 Jan 2015 11:42:57 +0100 X-Google-Sender-Auth: yGr7uzi5M26QW18lKnhcYqGyWwc Message-ID: Subject: Re: [PATCH] arch: m68k: mvme147: config.c: Remove unused function From: Geert Uytterhoeven To: Rickard Strandqvist Cc: linux-m68k , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 5, 2015 at 12:39 PM, Geert Uytterhoeven wrote: > On Thu, Jan 1, 2015 at 5:49 PM, Rickard Strandqvist > wrote: >> Remove the function mvme147_init_console_port() that is not used anywhere. >> >> This was partially found by using a static code analysis program called cppcheck. >> >> Signed-off-by: Rickard Strandqvist >> --- >> arch/m68k/mvme147/config.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c >> index 1bb3ce6..5da5e6e 100644 >> --- a/arch/m68k/mvme147/config.c >> +++ b/arch/m68k/mvme147/config.c >> @@ -209,8 +209,3 @@ void m147_scc_write (struct console *co, const char *str, unsigned count) >> } >> local_irq_restore(flags); >> } >> - >> -void mvme147_init_console_port (struct console *co, int cflag) >> -{ >> - co->write = m147_scc_write; >> -} > > And after that m147_scc_write() becomes unused, and scc_write(), and > scc_delay()... I will remove these, too. Thanks, applied and queued for 3.20. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds