* [PATCH] arch: m68k: mvme147: config.c: Remove unused function
@ 2015-01-01 16:49 Rickard Strandqvist
2015-01-05 11:39 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-01 16:49 UTC (permalink / raw)
To: Geert Uytterhoeven, linux-m68k; +Cc: Rickard Strandqvist, linux-kernel
Remove the function mvme147_init_console_port() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
arch/m68k/mvme147/config.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c
index 1bb3ce6..5da5e6e 100644
--- a/arch/m68k/mvme147/config.c
+++ b/arch/m68k/mvme147/config.c
@@ -209,8 +209,3 @@ void m147_scc_write (struct console *co, const char *str, unsigned count)
}
local_irq_restore(flags);
}
-
-void mvme147_init_console_port (struct console *co, int cflag)
-{
- co->write = m147_scc_write;
-}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arch: m68k: mvme147: config.c: Remove unused function
2015-01-01 16:49 [PATCH] arch: m68k: mvme147: config.c: Remove unused function Rickard Strandqvist
@ 2015-01-05 11:39 ` Geert Uytterhoeven
2015-01-11 10:42 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-01-05 11:39 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: linux-m68k, linux-kernel@vger.kernel.org
On Thu, Jan 1, 2015 at 5:49 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Remove the function mvme147_init_console_port() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/m68k/mvme147/config.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c
> index 1bb3ce6..5da5e6e 100644
> --- a/arch/m68k/mvme147/config.c
> +++ b/arch/m68k/mvme147/config.c
> @@ -209,8 +209,3 @@ void m147_scc_write (struct console *co, const char *str, unsigned count)
> }
> local_irq_restore(flags);
> }
> -
> -void mvme147_init_console_port (struct console *co, int cflag)
> -{
> - co->write = m147_scc_write;
> -}
And after that m147_scc_write() becomes unused, and scc_write(), and
scc_delay()... I will remove these, too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arch: m68k: mvme147: config.c: Remove unused function
2015-01-05 11:39 ` Geert Uytterhoeven
@ 2015-01-11 10:42 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-01-11 10:42 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: linux-m68k, linux-kernel@vger.kernel.org
On Mon, Jan 5, 2015 at 12:39 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Jan 1, 2015 at 5:49 PM, Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se> wrote:
>> Remove the function mvme147_init_console_port() that is not used anywhere.
>>
>> This was partially found by using a static code analysis program called cppcheck.
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>> ---
>> arch/m68k/mvme147/config.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/arch/m68k/mvme147/config.c b/arch/m68k/mvme147/config.c
>> index 1bb3ce6..5da5e6e 100644
>> --- a/arch/m68k/mvme147/config.c
>> +++ b/arch/m68k/mvme147/config.c
>> @@ -209,8 +209,3 @@ void m147_scc_write (struct console *co, const char *str, unsigned count)
>> }
>> local_irq_restore(flags);
>> }
>> -
>> -void mvme147_init_console_port (struct console *co, int cflag)
>> -{
>> - co->write = m147_scc_write;
>> -}
>
> And after that m147_scc_write() becomes unused, and scc_write(), and
> scc_delay()... I will remove these, too.
Thanks, applied and queued for 3.20.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-11 10:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-01 16:49 [PATCH] arch: m68k: mvme147: config.c: Remove unused function Rickard Strandqvist
2015-01-05 11:39 ` Geert Uytterhoeven
2015-01-11 10:42 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).