linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	Biju Das <biju.das.jz@bp.renesas.com>,
	 Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	 Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 4/6] arm64: dts: renesas: r9a09g077: Add USB2.0 support
Date: Wed, 3 Sep 2025 16:05:21 +0200	[thread overview]
Message-ID: <CAMuHMdWPst=JAbyL43SZAHTrCR=wajs15JZXCH4kmM41cdAh5w@mail.gmail.com> (raw)
In-Reply-To: <20250821161946.1096033-5-prabhakar.mahadev-lad.rj@bp.renesas.com>

Hi Prabhakar,

On Thu, 21 Aug 2025 at 18:19, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add EHCI, OHCI, PHY and HSUSB nodes to RZ/T2H (R9A09G077) SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a09g077.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g077.dtsi

> +               hsusb: usb@92041000 {
> +                       compatible = "renesas,usbhs-r9a09g077";
> +                       reg = <0 0x92041000 0 0x10000>;

"0x1000", as the region starting at 0x92043000 is marked reserved?
I can fix that while applying.

> +                       interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 588 IRQ_TYPE_LEVEL_HIGH>,
> +                                    <GIC_SPI 589 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&cpg CPG_MOD 408>;
> +                       phys = <&usb2_phy 3>;
> +                       phy-names = "usb";
> +                       power-domains = <&cpg>;
> +                       status = "disabled";
> +               };
> +
>                 sdhi0: mmc@92080000  {
>                         compatible = "renesas,sdhi-r9a09g077",
>                                      "renesas,sdhi-r9a09g057";

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2025-09-03 14:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21 16:19 [PATCH 0/6] arm64: dts: renesas: Add support for WDT/USB2.0 on RZ/{T2H,N2H} SoCs and EVKs Prabhakar
2025-08-21 16:19 ` [PATCH 1/6] arm64: dts: renesas: r9a09g077: Add WDT nodes Prabhakar
2025-09-03 13:47   ` Geert Uytterhoeven
2025-08-21 16:19 ` [PATCH 2/6] arm64: dts: renesas: r9a09g087: " Prabhakar
2025-09-03 13:48   ` Geert Uytterhoeven
2025-08-21 16:19 ` [PATCH 3/6] arm64: dts: renesas: rzt2h-evk-common: Enable WDT2 Prabhakar
2025-09-03 13:49   ` Geert Uytterhoeven
2025-09-04  9:51     ` Geert Uytterhoeven
2025-08-21 16:19 ` [PATCH 4/6] arm64: dts: renesas: r9a09g077: Add USB2.0 support Prabhakar
2025-09-03 14:05   ` Geert Uytterhoeven [this message]
2025-09-03 14:51     ` Lad, Prabhakar
2025-09-04  9:02       ` Geert Uytterhoeven
2025-08-21 16:19 ` [PATCH 5/6] arm64: dts: renesas: r9a09g087: " Prabhakar
2025-09-03 14:06   ` Geert Uytterhoeven
2025-09-04  9:02     ` Geert Uytterhoeven
2025-08-21 16:19 ` [PATCH 6/6] arm64: dts: renesas: rzt2h-n2h-evk: Enable " Prabhakar
2025-09-03 15:04   ` Geert Uytterhoeven
2025-09-03 19:20     ` Lad, Prabhakar
2025-09-04  7:51       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdWPst=JAbyL43SZAHTrCR=wajs15JZXCH4kmM41cdAh5w@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).