From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michal Simek <monstr@monstr.eu>
Cc: Michal Simek <michal.simek@xilinx.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Eric Paris <eparis@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] audit: Fix decimal constant description
Date: Mon, 24 Jun 2013 11:03:51 +0200 [thread overview]
Message-ID: <CAMuHMdWnA0LiLc+aYhZyHGpykFc_Xb0j2MWSPKLKQKaH910pcA@mail.gmail.com> (raw)
In-Reply-To: <51AF50CE.5050607@monstr.eu>
On Wed, Jun 5, 2013 at 4:53 PM, Michal Simek <monstr@monstr.eu> wrote:
> any comment on this?
>
> Geert: I fixes one warning reported in your regression log.
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> On 05/23/2013 08:03 AM, Michal Simek wrote:
>> Use proper decimal type for comparison with u32.
>>
>> Compilation warning was introduced by:
>> "audit: Make testing for a valid loginuid explicit."
>> (sha1: 780a7654cee8d61819512385e778e4827db4bfbc)
>>
>> Warning:
>> kernel/auditfilter.c: In function 'audit_data_to_entry':
>> kernel/auditfilter.c:426:3: warning: this decimal constant
>> is unsigned only in ISO C90 [enabled by default]
>> if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> CC: Al Viro <viro@zeniv.linux.org.uk>
>> CC: Eric Paris <eparis@redhat.com>
>> ---
>> kernel/auditfilter.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
>> index 83a2970..cfa1f73 100644
>> --- a/kernel/auditfilter.c
>> +++ b/kernel/auditfilter.c
>> @@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
>> f->lsm_rule = NULL;
>>
>> /* Support legacy tests for a valid loginuid */
>> - if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>> + if ((f->type == AUDIT_LOGINUID) && (f->val == ~0U)) {
>> f->type = AUDIT_LOGINUID_SET;
>> f->val = 0;
>> }
>> --
>> 1.8.2.3
>>
>
>
> --
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
>
>
--
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2013-06-24 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 6:03 [PATCH] audit: Fix decimal constant description Michal Simek
2013-06-05 14:53 ` Michal Simek
2013-06-24 9:03 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWnA0LiLc+aYhZyHGpykFc_Xb0j2MWSPKLKQKaH910pcA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).