* [PATCH] audit: Fix decimal constant description
@ 2013-05-23 6:03 Michal Simek
2013-06-05 14:53 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2013-05-23 6:03 UTC (permalink / raw)
To: linux-kernel; +Cc: monstr, Al Viro, Eric Paris
[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]
Use proper decimal type for comparison with u32.
Compilation warning was introduced by:
"audit: Make testing for a valid loginuid explicit."
(sha1: 780a7654cee8d61819512385e778e4827db4bfbc)
Warning:
kernel/auditfilter.c: In function 'audit_data_to_entry':
kernel/auditfilter.c:426:3: warning: this decimal constant
is unsigned only in ISO C90 [enabled by default]
if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
CC: Al Viro <viro@zeniv.linux.org.uk>
CC: Eric Paris <eparis@redhat.com>
---
kernel/auditfilter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 83a2970..cfa1f73 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
f->lsm_rule = NULL;
/* Support legacy tests for a valid loginuid */
- if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
+ if ((f->type == AUDIT_LOGINUID) && (f->val == ~0U)) {
f->type = AUDIT_LOGINUID_SET;
f->val = 0;
}
--
1.8.2.3
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] audit: Fix decimal constant description
2013-05-23 6:03 [PATCH] audit: Fix decimal constant description Michal Simek
@ 2013-06-05 14:53 ` Michal Simek
2013-06-24 9:03 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2013-06-05 14:53 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, Al Viro, Eric Paris, Geert Uytterhoeven,
Andrew Morton, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]
Hi guys,
any comment on this?
Geert: I fixes one warning reported in your regression log.
Thanks,
Michal
On 05/23/2013 08:03 AM, Michal Simek wrote:
> Use proper decimal type for comparison with u32.
>
> Compilation warning was introduced by:
> "audit: Make testing for a valid loginuid explicit."
> (sha1: 780a7654cee8d61819512385e778e4827db4bfbc)
>
> Warning:
> kernel/auditfilter.c: In function 'audit_data_to_entry':
> kernel/auditfilter.c:426:3: warning: this decimal constant
> is unsigned only in ISO C90 [enabled by default]
> if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> CC: Al Viro <viro@zeniv.linux.org.uk>
> CC: Eric Paris <eparis@redhat.com>
> ---
> kernel/auditfilter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 83a2970..cfa1f73 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
> f->lsm_rule = NULL;
>
> /* Support legacy tests for a valid loginuid */
> - if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
> + if ((f->type == AUDIT_LOGINUID) && (f->val == ~0U)) {
> f->type = AUDIT_LOGINUID_SET;
> f->val = 0;
> }
> --
> 1.8.2.3
>
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] audit: Fix decimal constant description
2013-06-05 14:53 ` Michal Simek
@ 2013-06-24 9:03 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2013-06-24 9:03 UTC (permalink / raw)
To: Michal Simek
Cc: Michal Simek, linux-kernel@vger.kernel.org, Al Viro, Eric Paris,
Andrew Morton, Greg Kroah-Hartman
On Wed, Jun 5, 2013 at 4:53 PM, Michal Simek <monstr@monstr.eu> wrote:
> any comment on this?
>
> Geert: I fixes one warning reported in your regression log.
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> On 05/23/2013 08:03 AM, Michal Simek wrote:
>> Use proper decimal type for comparison with u32.
>>
>> Compilation warning was introduced by:
>> "audit: Make testing for a valid loginuid explicit."
>> (sha1: 780a7654cee8d61819512385e778e4827db4bfbc)
>>
>> Warning:
>> kernel/auditfilter.c: In function 'audit_data_to_entry':
>> kernel/auditfilter.c:426:3: warning: this decimal constant
>> is unsigned only in ISO C90 [enabled by default]
>> if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> CC: Al Viro <viro@zeniv.linux.org.uk>
>> CC: Eric Paris <eparis@redhat.com>
>> ---
>> kernel/auditfilter.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
>> index 83a2970..cfa1f73 100644
>> --- a/kernel/auditfilter.c
>> +++ b/kernel/auditfilter.c
>> @@ -423,7 +423,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
>> f->lsm_rule = NULL;
>>
>> /* Support legacy tests for a valid loginuid */
>> - if ((f->type == AUDIT_LOGINUID) && (f->val == 4294967295)) {
>> + if ((f->type == AUDIT_LOGINUID) && (f->val == ~0U)) {
>> f->type = AUDIT_LOGINUID_SET;
>> f->val = 0;
>> }
>> --
>> 1.8.2.3
>>
>
>
> --
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
>
>
--
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-24 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 6:03 [PATCH] audit: Fix decimal constant description Michal Simek
2013-06-05 14:53 ` Michal Simek
2013-06-24 9:03 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).