Re: [PATCH v1] arm64: dts: renesas: r8a779g0: Add new gsx node for V4H

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Anh,

On Mon, 25 Aug 2025 at 06:37, Anh Nguyen <anh.nguyen.pv@renesas.com> wrote:
> From 8a8391bc4ceaac5248267851b71c9cce6b5c434a Mon Sep 17 00:00:00 2001
> From: Anh Nguyen <anh.nguyen.pv@renesas.com>
> Date: Thu, 21 Aug 2025 10:01:30 +0700
> Subject: [PATCH 2/2] arm64: dts: renesas: r8a779g0: Add new gsx node for V4H SoC
>
> Add new gsx node to enable GPU for V4H SoC
>
> Signed-off-by: Anh Nguyen <anh.nguyen.pv@renesas.com>
> Reviewed-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
> @@ -2121,6 +2121,15 @@ gic: interrupt-controller@f1000000 {
>                         interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> +               gsx: gsx@fd000000 {
> +                       compatible = "renesas,gsx";

This compatible value is not documented.  However, I don't think this
can be used as-is.  I think the property should look like:

    compatible = "renesas,r8a779g0-gpu", "img,img-axm-8-256".

The first step would be to add it to the DT bindings in
Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml.
Furthermore, support for this variant should be added to the driver
under drivers/gpu/drm/imagination/.
And where to get the firmware required to operate the GPU?

> +                       reg = <0 0xfd000000 0 0x800000>;
> +                       interrupts = <GIC_SPI 464 IRQ_TYPE_LEVEL_HIGH>;

According to the documentation, there are 8 interrupts?

> +                       clocks = <&cpg CPG_MOD 0>;
> +                       power-domains = <&sysc R8A779G0_PD_A23DGB>;
> +                       resets = <&cpg 0>;
> +               };
> +
>                 csi40: csi2@fe500000 {
>                         compatible = "renesas,r8a779g0-csi2";
>                         reg = <0 0xfe500000 0 0x40000>;

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds