From: Baptiste Reynal <b.reynal@virtualopensystems.com>
To: Auger Eric <eric.auger@linaro.org>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
Alex Williamson <alex.williamson@redhat.com>,
arnd@arndb.de, dan.carpenter@oracle.com,
"open list:VFIO DRIVER" <kvm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH] vfio: platform: mark symbols static where possible
Date: Thu, 1 Sep 2016 14:09:46 +0200 [thread overview]
Message-ID: <CAN9JPjHDDixh2kd1NSngE=oDZuuKVK4GmOee6s0YBP_ESTKVBg@mail.gmail.com> (raw)
In-Reply-To: <8555db5b-245f-a142-bcd2-42d2e7f2051e@linaro.org>
On Thu, Sep 1, 2016 at 1:41 PM, Auger Eric <eric.auger@linaro.org> wrote:
>
> Hi Baoyou,
>
> On 01/09/2016 13:15, Baoyou Xie wrote:
> > We get a few warnings when building kernel with W=1:
> > drivers/vfio/platform/vfio_platform_common.c:76:5: warning: no previous prototype for 'vfio_platform_acpi_call_reset' [-Wmissing-prototypes]
> > drivers/vfio/platform/vfio_platform_common.c:98:6: warning: no previous prototype for 'vfio_platform_acpi_has_reset' [-Wmissing-prototypes]
> > drivers/vfio/platform/vfio_platform_common.c:640:5: warning: no previous prototype for 'vfio_platform_of_probe' [-Wmissing-prototypes]
> > drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:59:5: warning: no previous prototype for 'vfio_platform_amdxgbe_reset' [-Wmissing-prototypes]
> > drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c:60:5: warning: no previous prototype for 'vfio_platform_calxedaxgmac_reset' [-Wmissing-prototypes]
> > ....
> >
> > In fact, these functions are only used in the file in which they are
> > declared and don't need a declaration, but can be made static.
> > so this patch marks these functions with 'static'.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> > ---
> > drivers/vfio/platform/reset/vfio_platform_amdxgbe.c | 2 +-
> > drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 +-
> > drivers/vfio/platform/vfio_platform_common.c | 6 +++---
> > 3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> > index d4030d0..bcd419c 100644
> > --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> > +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
> > @@ -56,7 +56,7 @@ static void xmdio_write(void *ioaddr, unsigned int mmd,
> > iowrite32(value, ioaddr + ((mmd_address & 0xff) << 2));
> > }
> >
> > -int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)
> > +static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)
> > {
> > struct vfio_platform_region *xgmac_regs = &vdev->regions[0];
> > struct vfio_platform_region *xpcs_regs = &vdev->regions[1];
> > diff --git a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
> > index e3d3d94..49e5df6 100644
> > --- a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
> > +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c
> > @@ -57,7 +57,7 @@ static inline void xgmac_mac_disable(void __iomem *ioaddr)
> > writel(value, ioaddr + XGMAC_CONTROL);
> > }
> >
> > -int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev)
> > +static int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev)
> > {
> > struct vfio_platform_region *reg = &vdev->regions[0];
> >
> > diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> > index 1cf2d46..d781428 100644
> > --- a/drivers/vfio/platform/vfio_platform_common.c
> > +++ b/drivers/vfio/platform/vfio_platform_common.c
> > @@ -73,7 +73,7 @@ static int vfio_platform_acpi_probe(struct vfio_platform_device *vdev,
> > return WARN_ON(!vdev->acpihid) ? -EINVAL : 0;
> > }
> >
> > -int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
> > +static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
> > const char **extra_dbg)
> > {
> > #ifdef CONFIG_ACPI
> > @@ -95,7 +95,7 @@ int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
> > #endif
> > }
> >
> > -bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)
> > +static bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)
> > {
> > #ifdef CONFIG_ACPI
> > struct device *dev = vdev->device;
> > @@ -637,7 +637,7 @@ static const struct vfio_device_ops vfio_platform_ops = {
> > .mmap = vfio_platform_mmap,
> > };
> >
> > -int vfio_platform_of_probe(struct vfio_platform_device *vdev,
> > +static int vfio_platform_of_probe(struct vfio_platform_device *vdev,
> > struct device *dev)
> > {
> > int ret;
> >
>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>
>
> Thanks!
>
> Eric
Reviewed-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
Thanks,
Baptiste
next prev parent reply other threads:[~2016-09-01 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 11:15 [PATCH] vfio: platform: mark symbols static where possible Baoyou Xie
2016-09-01 11:23 ` Arnd Bergmann
2016-09-01 11:41 ` Auger Eric
2016-09-01 12:09 ` Baptiste Reynal [this message]
2016-09-13 22:18 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN9JPjHDDixh2kd1NSngE=oDZuuKVK4GmOee6s0YBP_ESTKVBg@mail.gmail.com' \
--to=b.reynal@virtualopensystems.com \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=eric.auger@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).