linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <jstultz@google.com>
To: Sumanth Gavini <sumanth.gavini@yahoo.com>
Cc: boqun.feng@gmail.com, clingutla@codeaurora.org,
	elavila@google.com,  gregkh@linuxfoundation.org,
	kprateek.nayak@amd.com,  linux-kernel@vger.kernel.org,
	mhiramat@kernel.org, mingo@kernel.org,  rostedt@goodmis.org,
	ryotkkr98@gmail.com, sashal@kernel.org,  stable@vger.kernel.org,
	tglx@linutronix.de
Subject: Re: [PATCH 6.1] softirq: Add trace points for tasklet entry/exit
Date: Thu, 21 Aug 2025 15:05:16 -0700	[thread overview]
Message-ID: <CANDhNCoao7P8RWbugxY70K-+HRPSy=NypgNXM3DjheHRmznmjw@mail.gmail.com> (raw)
In-Reply-To: <20250821210208.1724231-1-sumanth.gavini@yahoo.com>

On Thu, Aug 21, 2025 at 2:02 PM Sumanth Gavini <sumanth.gavini@yahoo.com> wrote:
> >>
> >> Just following up on my patch submitted with subject "Subject: [PATCH 6.1] softirq: Add trace points for tasklet entry/exit".
> >>
> >> Original message: https://lore.kernel.org/all/20250812161755.609600-1-sumanth.gavini@yahoo.com/
> >>
> >> Would you have any feedback on this change? I'd be happy to address any comments or concerns.
> >>
> >> This patch fixes this three bugs
> >> 1. https://syzkaller.appspot.com/bug?extid=5284a86a0b0a31ab266a
> >> 2. https://syzkaller.appspot.com/bug?extid=296695c8ae3c7da3d511
> >> 3. https://syzkaller.appspot.com/bug?extid=97f2ac670e5e7a3b48e4
>
> > How does a patch adding a tracepoint fix the bugs highlighted here?
> > It seems maybe it would help in debugging those issues, but I'm not
> > sure I see how it would fix them.
>
> This patch is related to linux 6.1/backports, the backports(https://syzkaller.appspot.com/linux-6.1/backports)
> I see this patch would fix these bugs. Let me know if my understand is wrong.

But that doesn't explain why or how it fixes the bugs.  I'm not
opposed to stable taking this, but the reasoning should be clear, if
that is the motivation for including this change.
I fret there is something incidental in this patch that avoids the
problem, and that those issues may need a deeper fix rather then to
hide them with this change.

thanks
-john

  reply	other threads:[~2025-08-21 22:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250812161755.609600-1-sumanth.gavini.ref@yahoo.com>
2025-08-12 16:17 ` [PATCH 6.1] softirq: Add trace points for tasklet entry/exit Sumanth Gavini
2025-08-21 18:40   ` Sumanth Gavini
2025-08-21 18:54     ` John Stultz
2025-08-21 21:02       ` Sumanth Gavini
2025-08-21 22:05         ` John Stultz [this message]
2025-08-22 13:07   ` Greg KH
2025-08-23 17:42     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANDhNCoao7P8RWbugxY70K-+HRPSy=NypgNXM3DjheHRmznmjw@mail.gmail.com' \
    --to=jstultz@google.com \
    --cc=boqun.feng@gmail.com \
    --cc=clingutla@codeaurora.org \
    --cc=elavila@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=ryotkkr98@gmail.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=sumanth.gavini@yahoo.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).