linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Strachan <astrachan@google.com>
To: mr.ray.clinton@gmail.com
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Todd Kjos" <tkjos@android.com>,
	"Martijn Coenen" <maco@android.com>,
	"Nathan Chancellor" <natechancellor@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	trivial@kernel.org
Subject: Re: [PATCH] Trivial numbering change in comments.
Date: Tue, 28 Aug 2018 14:43:57 -0700	[thread overview]
Message-ID: <CANDihLFMz8soniUeCgJp4qPPAeOf2OM742BvMHsLfhPOfqSyDA@mail.gmail.com> (raw)
In-Reply-To: <CAPMnawu33A5L5a6a00tZ+_9cQxyN97OwXK0sO9Q60+YvR=Yg_A@mail.gmail.com>

On Tue, Aug 28, 2018 at 1:08 PM Ray Clinton <mr.ray.clinton@gmail.com> wrote:
> I'm trying to get my feet wet in kernel dev and while working on a patch
> I noticed in a lengthy comment block that the number "2" was skipped
> in a description of the steps of a protocol. This patch is simply correcting
> this. This is for 4.18.0.
>
> It is a very trivial patch, but this is my first actual try at one and
> thought I
> might start out small (and I don't think you can get smaller than a single
>  character change). Any and all advice (about this patch, email, or
> anything else) is very welcome.
>
> Thanks so much!
> Ray
>
> Signed-off-by: Ray Clinton <mr.ray.clinton@gmail.com>

Acked-by: Alistair Strachan <astrachan@google.com>

> ---
>  drivers/staging/android/uapi/vsoc_shm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/uapi/vsoc_shm.h
> b/drivers/staging/android/uapi/vsoc_shm.h
> index 6291fb2..0301172 100644
> --- a/drivers/staging/android/uapi/vsoc_shm.h
> +++ b/drivers/staging/android/uapi/vsoc_shm.h
> @@ -92,7 +92,7 @@ struct fd_scoped_permission_arg {
>   *    The transmitter can choose any appropriate hashing algorithm, including
>   *    hash = futex_offset & ((1 << num_nodes_lg2) - 1)
>   *
> - * 3. The transmitter should atomically compare and swap futex_offset with 0
> + * 2. The transmitter should atomically compare and swap futex_offset with 0
>   *    at hash. There are 3 possible outcomes
>   *      a. The swap fails because the futex_offset is already in the table.
>   *         The transmitter should stop.
> --
> 2.7.4

  reply	other threads:[~2018-08-28 21:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 20:08 [PATCH] Trivial numbering change in comments Ray Clinton
2018-08-28 21:43 ` Alistair Strachan [this message]
2018-08-28 22:03 ` Nathan Chancellor
2018-08-28 22:28   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANDihLFMz8soniUeCgJp4qPPAeOf2OM742BvMHsLfhPOfqSyDA@mail.gmail.com \
    --to=astrachan@google.com \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=mr.ray.clinton@gmail.com \
    --cc=natechancellor@gmail.com \
    --cc=tkjos@android.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).