From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751854Ab2CFFtZ (ORCPT ); Tue, 6 Mar 2012 00:49:25 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:54901 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635Ab2CFFtY (ORCPT ); Tue, 6 Mar 2012 00:49:24 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of tomoya.rohm@gmail.com designates 10.68.190.8 as permitted sender) smtp.mail=tomoya.rohm@gmail.com; dkim=pass header.i=tomoya.rohm@gmail.com MIME-Version: 1.0 In-Reply-To: <20120302130509.GF3230@opensource.wolfsonmicro.com> References: <1329976011-2251-1-git-send-email-tomoya.rohm@gmail.com> <1329976011-2251-3-git-send-email-tomoya.rohm@gmail.com> <20120302130509.GF3230@opensource.wolfsonmicro.com> Date: Tue, 6 Mar 2012 14:49:24 +0900 Message-ID: Subject: Re: [PATCH v5] sound/soc/lapis: add machine driver for ML7213 Carrier Board From: Tomoya MORINAGA To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2012年3月2日22:05 Mark Brown : > On Thu, Feb 23, 2012 at 02:46:51PM +0900, Tomoya MORINAGA wrote: > >> This option enables support for the AC Link Controllers in ML7213 IOH SoC. >> +config SND_SOC_ML7213_MACHINE >> + tristate "ML7213 IOH ASoC machine driver" >> + select SND_SOC_ML7213_PLATFORM >> + help >> + This is ASoC machine driver for ML7213 IOH > > This needs to depend on the CODEC as well, how have you tested? OK, will add this. When I test this, I selected "Build all ASoC ...." of Kconfig > You're also missing a blank line between this and the previous stanza. Sorry, I can't understand your saying. > >> +static struct platform_device *ioh_snd_device; >> + >> + >> +static int __init ioh_i2s_init(void) >> +{ >> + int ret; >> + ioh_snd_device = platform_device_alloc("soc-audio", -1); >> + if (!ioh_snd_device) >> + return -ENOMEM; > > Use snd_soc_register_card() and a real device. OK. As a matter of interest, why do you recommend me to use snd_soc_register_card() ? At present, many ASoC drivers use platform_device_alloc. thanks, -- ROHM Co., Ltd. tomoya