From: Shaohua Li <shli@kernel.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [patch]blk: use correct sectors limitation for discard request
Date: Wed, 21 Mar 2012 09:26:45 +0800 [thread overview]
Message-ID: <CANejiEUcBVOA9iSw6viVia-3jduYmO28FuH-TgDFicnsfKmNGQ@mail.gmail.com> (raw)
In-Reply-To: <20120320163142.GF17071@redhat.com>
2012/3/21 Vivek Goyal <vgoyal@redhat.com>:
> On Fri, Mar 16, 2012 at 03:40:06PM +0800, Shaohua Li wrote:
>>
>> Subject: blk: use correct sectors limitation for discard request
>>
>> max_discard_sectors doesn't equal to max_sectors/max_hw_sectors.
>> Without this,
>> discard request merge might be ignored.
>
> In other patch you are making discard request non-mergeable. So what's
> the purpose of this patch.
Yep, this one has no effect with that patch. But this is a bug, and eventually
we will support discard merge. Just to make sure it doesn't slip away.
prev parent reply other threads:[~2012-03-21 1:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 7:40 [patch]blk: use correct sectors limitation for discard request Shaohua Li
2012-03-20 16:31 ` Vivek Goyal
2012-03-21 1:26 ` Shaohua Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANejiEUcBVOA9iSw6viVia-3jduYmO28FuH-TgDFicnsfKmNGQ@mail.gmail.com \
--to=shli@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).