linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qiu-ji Chen <chenqiuji666@gmail.com>
To: Eugen Hristev <eugen.hristev@linaro.org>
Cc: sean.wang@mediatek.com, vkoul@kernel.org, matthias.bgg@gmail.com,
	 angelogioacchino.delregno@collabora.com,
	dmaengine@vger.kernel.org,  linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	 linux-kernel@vger.kernel.org, baijiaju1990@gmail.com,
	stable@vger.kernel.org,  kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] dmaengine: mediatek: Fix a flag reuse error in mtk_cqdma_tx_status()
Date: Fri, 6 Jun 2025 17:14:00 +0800	[thread overview]
Message-ID: <CANgpojXWk1zvu32bMuGgkVGVNvPw+0NWmSUC62Sbc3WcUXAd3A@mail.gmail.com> (raw)
In-Reply-To: <ff77f70e-344d-4b8a-a27f-c8287d49339c@linaro.org>

> On 6/6/25 10:17, Qiu-ji Chen wrote:
> > Fixed a flag reuse bug in the mtk_cqdma_tx_status() function.
> If the first spin_lock_irqsave already saved the irq flags and disabled
> them, would it be meaningful to actually use a simple spin_lock for the
> second lock ? Or rather spin_lock_nested since there is a second nested
> lock taken ?
>
> Eugen
>

Hello Eugen,

Thanks for helpful suggestion. The modification has been submitted in
patch v2 as discussed.

Best regards,
Qiu-ji Chen

  reply	other threads:[~2025-06-06  9:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-06  7:17 [PATCH] dmaengine: mediatek: Fix a flag reuse error in mtk_cqdma_tx_status() Qiu-ji Chen
2025-06-06  7:42 ` Eugen Hristev
2025-06-06  9:14   ` Qiu-ji Chen [this message]
2025-06-06 10:00     ` Eugen Hristev
2025-06-06 17:48       ` Qiu-ji Chen
2025-06-11 13:04         ` Eugen Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANgpojXWk1zvu32bMuGgkVGVNvPw+0NWmSUC62Sbc3WcUXAd3A@mail.gmail.com \
    --to=chenqiuji666@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=baijiaju1990@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=eugen.hristev@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=sean.wang@mediatek.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).