linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Daniel Almeida" <daniel.almeida@collabora.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v15 3/3] rust: platform: add resource accessors
Date: Sat, 19 Jul 2025 18:19:53 +0200	[thread overview]
Message-ID: <CANiq72=LAaQuii3O_+Pa+wYSXyd_Joi8aecNGVqn5fww8PbZ7Q@mail.gmail.com> (raw)
In-Reply-To: <DBG25OQZJ18V.1W13FEOPX8MOH@kernel.org>

On Sat, Jul 19, 2025 at 3:15 PM Danilo Krummrich <dakr@kernel.org> wrote:
>
> @Miguel: What's the preferred way dealing with this? I assume we just want to
> ignore this warning for the affected compiler versions?

Yeah, we had this in the past -- when I introduced the lint, I just
went with putting in the middle, e.g. in `rust/kernel/sync/lock.rs`'s
`do_unlocked`.

It has been fairly confusing, because long ago AFAIU it was not
intended to be supported, but then they introduced a config option for
it, and then it was made the default, but there were false positives.

It seems it has been finally fixed in
https://github.com/rust-lang/rust-clippy/pull/13888 for Rust 1.87.0.

I would say just put it in the middle. The only advantage of using an
`allow` would be using the "reason" field to say we can move it >=
1.87, but if we really want to move it, we can always use a normal
comment to say so instead.

Cheers,
Miguel

  reply	other threads:[~2025-07-19 16:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-17 15:55 [PATCH v15 0/3] rust: platform: add Io support Daniel Almeida
2025-07-17 15:55 ` [PATCH v15 1/3] rust: io: add resource abstraction Daniel Almeida
2025-07-17 15:55 ` [PATCH v15 2/3] rust: io: mem: add a generic iomem abstraction Daniel Almeida
2025-07-17 19:45   ` Danilo Krummrich
2025-07-18 12:23     ` Daniel Almeida
2025-07-19 13:51   ` Danilo Krummrich
2025-07-19 14:08     ` [PATCH] rust: io: mem: enable IoRequest doc-tests Danilo Krummrich
2025-07-20 17:47       ` Danilo Krummrich
2025-07-17 15:55 ` [PATCH v15 3/3] rust: platform: add resource accessors Daniel Almeida
2025-07-19 13:15   ` Danilo Krummrich
2025-07-19 16:19     ` Miguel Ojeda [this message]
2025-07-19 16:29       ` Miguel Ojeda
2025-07-19  8:01 ` [PATCH v15 0/3] rust: platform: add Io support Greg Kroah-Hartman
2025-07-19 10:16   ` Danilo Krummrich
2025-07-20  0:34   ` Daniel Almeida
2025-07-20 17:46 ` Danilo Krummrich
2025-07-23  7:35 ` Dirk Behme
2025-07-23 13:33   ` Daniel Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72=LAaQuii3O_+Pa+wYSXyd_Joi8aecNGVqn5fww8PbZ7Q@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rafael@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).