From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Kees Cook <keescook@chromium.org>,
asmadeus@codewreck.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Jonathan Corbet <corbet@lwn.net>, Arnd Bergmann <arnd@arndb.de>,
dwmw@amazon.co.uk, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will.deacon@arm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
daniel@iogearbox.net, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive
Date: Sun, 26 Aug 2018 19:37:28 +0200 [thread overview]
Message-ID: <CANiq72kV0srrjF8CfzUntFT7KcdNQfnP8rF3RG44WR4j89uhjA@mail.gmail.com> (raw)
In-Reply-To: <1be357c91f6469c7a9b0e857fd15bad30347fd09.camel@perches.com>
Hi all,
On Fri, Aug 24, 2018 at 1:31 AM, Joe Perches <joe@perches.com> wrote:
> On Thu, 2018-08-23 at 16:12 -0700, Nick Desaulniers wrote:
>> On Thu, Aug 23, 2018 at 2:19 PM Joe Perches <joe@perches.com> wrote:
>> >
>> > On Thu, 2018-08-23 at 14:03 -0700, Nick Desaulniers wrote:
>> > > Not this case; it's how we get gnu89 semantics for `extern inline` is
>> > > not compiler specific (therefor should not go in a compiler specific
>> > > header).
>> >
>> > It's not possible to know that compilers support what
>> > __attribute__((<foo>)) and at what version that support
>> > exists unless it is specified somewhere.
>>
>> __has_attribute:
>> https://clang.llvm.org/docs/LanguageExtensions.html#has-attribute
>>
>> The release notes of GCC-5 mention __has_attribute.
>> https://gcc.gnu.org/gcc-5/changes.html
>
> So not available in the now minimum supported gcc 4.6?
>
We can workaround that until we have 5 as the minimum. I have tried
and the result is quite nice.
Sending the patch in a few moments -- compile-testing for a while
allmodconfig on both 4.6 and 8.2...
Cheers,
Miguel
next prev parent reply other threads:[~2018-08-26 17:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 23:37 [PATCH] include/linux/compiler*.h: make compiler-*.h mutually exclusive Nick Desaulniers
2018-08-23 0:20 ` Joe Perches
2018-08-23 0:21 ` Linus Torvalds
2018-08-23 0:25 ` Dominique Martinet
2018-08-23 1:02 ` Linus Torvalds
2018-08-23 1:10 ` Dominique Martinet
2018-08-23 1:13 ` Linus Torvalds
2018-08-23 8:32 ` Kees Cook
2018-08-23 21:03 ` Nick Desaulniers
2018-08-23 21:10 ` Joe Perches
2018-08-23 21:19 ` Joe Perches
2018-08-23 23:12 ` Nick Desaulniers
2018-08-23 23:31 ` Joe Perches
2018-08-26 17:37 ` Miguel Ojeda [this message]
2018-08-23 22:08 ` Dominique Martinet
2018-08-23 2:42 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72kV0srrjF8CfzUntFT7KcdNQfnP8rF3RG44WR4j89uhjA@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=asmadeus@codewreck.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dwmw@amazon.co.uk \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).