[PATCH] rust: sync: Update ARef and AlwaysRefCounted imports from sync::aref

[PATCH] rust: sync: Update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

Update the in-file reference of sync/aref.rs to import `ARef` and
`AlwaysRefCounted` from `sync::aref` instead of `types`.

This aligns with the ongoing effort to move `ARef` and
`AlwaysRefCounted` to sync.

Suggested-by: Benno Lossin <lossin@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1173
Fixes: 07dad44aa9a93 ("rust: kernel: move ARef and AlwaysRefCounted to sync::aref")
Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
---
This follows the commit [1] which moves ARef and AlwaysRefCounted modules to sync/aref.rs.

Apologies, I had missed out on changing the in-file reference call for the modules. This should fix that.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
---
 rust/kernel/sync/aref.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/sync/aref.rs b/rust/kernel/sync/aref.rs
index dbd77bb68617..c53d42cb0734 100644
--- a/rust/kernel/sync/aref.rs
+++ b/rust/kernel/sync/aref.rs
@@ -97,7 +97,7 @@ pub unsafe fn from_raw(ptr: NonNull<T>) -> Self {
     ///
     /// ```
     /// use core::ptr::NonNull;
-    /// use kernel::types::{ARef, AlwaysRefCounted};
+    /// use kernel::sync::aref::{ARef, AlwaysRefCounted};
     ///
     /// struct Empty {}
     ///

base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
-- 
2.34.1

Re: [PATCH] rust: sync: Update ARef and AlwaysRefCounted imports from sync::aref

[Benno Lossin]

On Mon Aug 18, 2025 at 9:10 PM CEST, Shankari Anand wrote:
> Update the in-file reference of sync/aref.rs to import `ARef` and
> `AlwaysRefCounted` from `sync::aref` instead of `types`.
>
> This aligns with the ongoing effort to move `ARef` and
> `AlwaysRefCounted` to sync.
>
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1173
> Fixes: 07dad44aa9a93 ("rust: kernel: move ARef and AlwaysRefCounted to sync::aref")
> Signed-off-by: Shankari Anand <shankari.ak0208@gmail.com>
> ---
> This follows the commit [1] which moves ARef and AlwaysRefCounted modules to sync/aref.rs.
>
> Apologies, I had missed out on changing the in-file reference call for the modules. This should fix that.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
> ---
>  rust/kernel/sync/aref.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Benno Lossin <lossin@kernel.org>

---
Cheers,
Benno

Re: [PATCH] rust: sync: Update ARef and AlwaysRefCounted imports from sync::aref

[Miguel Ojeda]

On Mon, Aug 18, 2025 at 9:11 PM Shankari Anand
<shankari.ak0208@gmail.com> wrote:
>
> Fixes: 07dad44aa9a93 ("rust: kernel: move ARef and AlwaysRefCounted to sync::aref")

> Apologies, I had missed out on changing the in-file reference call for the modules. This should fix that.

I am not sure if this should count as a fix -- it could have easily
been an intentional, second patch on top of the move, so that the move
is minimal to avoid modifying the lines at the same time, which is
something we typically do/want. :)

Thanks!

Cheers,
Miguel

Re: [PATCH] rust: sync: Update ARef and AlwaysRefCounted imports from sync::aref

[Shankari Anand]

On Tue, Aug 26, 2025 at 11:07:31AM +0200, Miguel Ojeda wrote:
> On Mon, Aug 18, 2025 at 9:11 PM Shankari Anand
> <shankari.ak0208@gmail.com> wrote:
> >
> > Fixes: 07dad44aa9a93 ("rust: kernel: move ARef and AlwaysRefCounted to sync::aref")
> 
> > Apologies, I had missed out on changing the in-file reference call for the modules. This should fix that.
> 
> I am not sure if this should count as a fix -- it could have easily
> been an intentional, second patch on top of the move, so that the move
> is minimal to avoid modifying the lines at the same time, which is
> something we typically do/want. :)
> 
> Thanks!

Hey, yep I agree. So should I drop the Fixes tag?
 
> Cheers,
> Miguel

Regards,
Shankari

Re: [PATCH] rust: sync: Update ARef and AlwaysRefCounted imports from sync::aref

[Miguel Ojeda]

On Thu, Aug 28, 2025 at 3:11 PM Shankari Anand
<shankari.ak0208@gmail.com> wrote:
>
> Hey, yep I agree. So should I drop the Fixes tag?

No worries, I can do that on apply.

Thanks for confirming there is nothing I was missing!

Cheers,
Miguel