From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: "WANG Rui" <wangrui@loongson.cn>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"WANG Xuerui" <kernel@xen0n.name>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
loongarch@lists.linux.dev, linux-doc@vger.kernel.org,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v1 0/2] Rust enablement for LoongArch
Date: Mon, 15 Jan 2024 17:08:11 +0100 [thread overview]
Message-ID: <CANiq72mEPnB7yEZvtUXAM5w0GgYmzdrM9OhioLGb_LzbAJKNOA@mail.gmail.com> (raw)
In-Reply-To: <CAAhV-H72Hbfy7n6+AFSFFOzizo0GtpzA074sgo48-W-Dt0VR+w@mail.gmail.com>
On Mon, Jan 15, 2024 at 4:23 AM Huacai Chen <chenhuacai@kernel.org> wrote:
>
> Thank you for your suggestion, but since this will be replaced by the
> built-in target soon, and I don't want to change the tag to make Linus
> unhappy. Let's leave it as is.
The issue is not a big deal and I appreciate that you made the effort
to enable Rust for your architecture. However, please note that we do
our best to maintain a clean formatting state for Rust code (i.e.
`rustfmt` should be run) and that people may see this in tests/CIs
that use the Make target.
I don't think Linus would mind too much, and you could point him to
this email if you want (or you could put the fix on top); but if you
really want to keep the tag as-is, then we should consider it as a fix
for this cycle, i.e. we should not wait for e.g. the next cycle for
the built-in target. Could you please send it through your tree as
soon as possible?
Cheers,
Miguel
next prev parent reply other threads:[~2024-01-15 16:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 3:21 [PATCH v1 0/2] Rust enablement for LoongArch WANG Rui
2024-01-08 3:21 ` [PATCH v1 1/2] Documentation: rust: Add a character to the first column WANG Rui
2024-01-08 3:21 ` [PATCH v1 2/2] LoongArch: Enable initial Rust support WANG Rui
2024-01-08 4:23 ` [PATCH v1 0/2] Rust enablement for LoongArch Huacai Chen
2024-01-09 9:54 ` Huacai Chen
2024-01-09 19:33 ` Boqun Feng
2024-01-10 1:41 ` WANG Rui
2024-01-10 2:09 ` Boqun Feng
2024-01-10 2:29 ` WANG Rui
2024-01-10 10:49 ` Miguel Ojeda
2024-01-11 3:16 ` WANG Rui
2024-01-14 15:43 ` Miguel Ojeda
2024-01-15 3:23 ` Huacai Chen
2024-01-15 16:08 ` Miguel Ojeda [this message]
2024-01-16 9:31 ` Huacai Chen
2024-01-16 15:15 ` Miguel Ojeda
2024-01-17 4:34 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72mEPnB7yEZvtUXAM5w0GgYmzdrM9OhioLGb_LzbAJKNOA@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=gary@garyguo.net \
--cc=kernel@xen0n.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wangrui@loongson.cn \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).