From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967332AbcA1AhJ (ORCPT ); Wed, 27 Jan 2016 19:37:09 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34102 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966234AbcA1Agv (ORCPT ); Wed, 27 Jan 2016 19:36:51 -0500 MIME-Version: 1.0 In-Reply-To: <1453937211.10099.31.camel@perches.com> References: <1453937211.10099.31.camel@perches.com> Date: Thu, 28 Jan 2016 00:36:50 +0000 Message-ID: Subject: Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface" From: Eric Curtin To: Joe Perches Cc: platform-driver-x86@vger.kernel.org, Kernel development list , Darren Hart , Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27 January 2016 at 23:26, Joe Perches wrote: > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote: >> Message gets logged on machines that are well supported. >> >> Signed-off-by: Eric Curtin >> --- >> drivers/platform/x86/thinkpad_acpi.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/platform/x86/thinkpad_acpi.c >> b/drivers/platform/x86/thinkpad_acpi.c >> index a268a7a..4eb41aa 100644 >> --- a/drivers/platform/x86/thinkpad_acpi.c >> +++ b/drivers/platform/x86/thinkpad_acpi.c >> @@ -6661,7 +6661,6 @@ static void __init >> tpacpi_detect_brightness_capabilities(void) >> pr_info("detected a 8-level brightness capable >> ThinkPad\n"); >> break; >> default: >> - pr_info("Unsupported brightness interface\n"); >> tp_features.bright_unkfw = 1; >> bright_maxlvl = b - 1; >> } > > Perhaps this should be something like this instead: > --- > drivers/platform/x86/thinkpad_acpi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index a268a7a..bd12c71 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -6653,18 +6653,16 @@ static void __init tpacpi_detect_brightness_capabilities(void) > switch (b) { > case 16: > bright_maxlvl = 15; > - pr_info("detected a 16-level brightness capable ThinkPad\n"); > break; > case 8: > case 0: > bright_maxlvl = 7; > - pr_info("detected a 8-level brightness capable ThinkPad\n"); > break; > default: > - pr_info("Unsupported brightness interface\n"); > tp_features.bright_unkfw = 1; > bright_maxlvl = b - 1; > } > + pr_info("detected %u brightness levels\n", bright_maxlvl + 1); > } > > static int __init brightness_init(struct ibm_init_struct *iibm) Maybe, but the other logging issues kinda mean something. There are many, many reports of people thinking their brightness interface is broken because of this logging message, when in reality the i915 driver supports their devices just fine as previously stated.