From: Toshiaki Yamane <yamanetoshi@gmail.com>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
Ian Abbott <ian.abbott@mev.co.uk>,
Frank Mori Hess <fmhess@users.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/comedi: Use dev_ printks in drivers/adl_pci8164.c
Date: Fri, 5 Oct 2012 18:36:33 +0900 [thread overview]
Message-ID: <CAOTypNTOuT-6M0X5yjpogQv9+1ArYesAnOknPyOEeKMtpReDbA@mail.gmail.com> (raw)
In-Reply-To: <506EA54F.1020807@mev.co.uk>
On Fri, Oct 5, 2012 at 6:15 PM, Ian Abbott <abbotti@mev.co.uk> wrote:
> On 2012-10-05 01:07, YAMANE Toshiaki wrote:
>>
>> fixed below checkpatch warning.
>> - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then
>> pr_err(... to printk(KERN_ERR ...
>>
>> Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
>> ---
>> drivers/staging/comedi/drivers/adl_pci8164.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/adl_pci8164.c
>> b/drivers/staging/comedi/drivers/adl_pci8164.c
>> index 05e06e7..6dbe465 100644
>> --- a/drivers/staging/comedi/drivers/adl_pci8164.c
>> +++ b/drivers/staging/comedi/drivers/adl_pci8164.c
>> @@ -89,9 +89,9 @@ static void adl_pci8164_insn_read(struct comedi_device
>> *dev,
>> }
>>
>> data[0] = inw(dev->iobase + axis_reg + offset);
>> - printk(KERN_DEBUG "comedi: pci8164 %s read -> "
>> - "%04X:%04X on axis
>> %s\n",
>> - action, data[0], data[1], axisname);
>> + dev_dbg(dev->class_dev,
>> + "comedi: pci8164 %s read -> %04X:%04X on axis %s\n",
>> + action, data[0], data[1], axisname);
>> }
>
>
> The "comedi: " prefix is superfluous, so should be removed. The dev_dbg()
> call will emit the word "comedi" twice already without the extra prefix.
>
>
>>
>> static int adl_pci8164_insn_read_msts(struct comedi_device *dev,
>> @@ -170,9 +170,9 @@ static void adl_pci8164_insn_out(struct comedi_device
>> *dev,
>>
>> outw(data[0], dev->iobase + axis_reg + offset);
>>
>> - printk(KERN_DEBUG "comedi: pci8164 %s write -> "
>> - "%04X:%04X on axis %s\n",
>> - action, data[0], data[1], axisname);
>> + dev_dbg(dev->class_dev,
>> + "comedi: pci8164 %s write -> %04X:%04X on axis %s\n",
>> + action, data[0], data[1], axisname);
>>
>> }
>
>
> Same here.
Ian-san,
Thank you for pointing out my mistakes.
I will try to fix it.
--
Regards,
YAMANE Toshiaki
next prev parent reply other threads:[~2012-10-05 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 0:07 [PATCH] staging/comedi: Use dev_ printks in drivers/adl_pci8164.c YAMANE Toshiaki
2012-10-05 9:15 ` Ian Abbott
2012-10-05 9:36 ` Toshiaki Yamane [this message]
2012-10-06 5:32 ` YAMANE Toshiaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOTypNTOuT-6M0X5yjpogQv9+1ArYesAnOknPyOEeKMtpReDbA@mail.gmail.com \
--to=yamanetoshi@gmail.com \
--cc=abbotti@mev.co.uk \
--cc=fmhess@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).