From: Tomas Glozar <tglozar@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
jkacur@redhat.com
Subject: Re: [PATCH] rtla/timerlat: Fix histogram ALL for zero samples
Date: Wed, 20 Nov 2024 06:04:05 +0100 [thread overview]
Message-ID: <CAP4=nvQ-J9uEm-mAnBhjLvy_LOzB4KvMoCBYeeo4w5_fMwbiow@mail.gmail.com> (raw)
In-Reply-To: <20241119102257.3df588ce@gandalf.local.home>
út 19. 11. 2024 v 16:22 odesílatel Steven Rostedt <rostedt@goodmis.org> napsal:
>
> There's a lot of duplicate code here. Can you please make a helper
> function, that at least has:
Good point, I thought it's not that bad when I was writing it, but
together with the already implemented ifs, this pattern is now there
19 times. I will send a v2 once I'm back from vacation.
Tomas
prev parent reply other threads:[~2024-11-20 5:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 13:48 [PATCH] rtla/timerlat: Fix histogram ALL for zero samples tglozar
2024-11-19 15:22 ` Steven Rostedt
2024-11-20 5:04 ` Tomas Glozar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP4=nvQ-J9uEm-mAnBhjLvy_LOzB4KvMoCBYeeo4w5_fMwbiow@mail.gmail.com' \
--to=tglozar@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox