From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755852AbcA2LkH (ORCPT ); Fri, 29 Jan 2016 06:40:07 -0500 Received: from mail-yk0-f172.google.com ([209.85.160.172]:34107 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755794AbcA2LkD (ORCPT ); Fri, 29 Jan 2016 06:40:03 -0500 MIME-Version: 1.0 In-Reply-To: <1453354002-28366-3-git-send-email-wens@csie.org> References: <1453354002-28366-1-git-send-email-wens@csie.org> <1453354002-28366-3-git-send-email-wens@csie.org> Date: Fri, 29 Jan 2016 12:40:03 +0100 Message-ID: Subject: Re: [PATCH RFC 02/15] mmc: sunxi: Return error on mmc_regulator_set_ocr() fail in .set_ios op From: Ulf Hansson To: Chen-Yu Tsai Cc: Maxime Ripard , Hans de Goede , linux-mmc , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-sunxi@googlegroups.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21 January 2016 at 06:26, Chen-Yu Tsai wrote: > Let .set_ios() fail if mmc_regulator_set_ocr() fails to enable and set a > proper voltage for vmmc. > > Signed-off-by: Chen-Yu Tsai Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/sunxi-mmc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c > index cce5ca540857..790f01662b4e 100644 > --- a/drivers/mmc/host/sunxi-mmc.c > +++ b/drivers/mmc/host/sunxi-mmc.c > @@ -711,7 +711,10 @@ static void sunxi_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > break; > > case MMC_POWER_UP: > - mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, ios->vdd); > + host->ferror = mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, > + ios->vdd); > + if (host->ferror) > + return; > > host->ferror = sunxi_mmc_init_host(mmc); > if (host->ferror) > -- > 2.7.0.rc3 >