From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F6B213E9C for ; Thu, 7 May 2026 02:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778120233; cv=none; b=AEggqoM/ao8qCXu60WSWoiYb/P8EjLGOt4pWDUwhOtJl/LU0OyJHv5Ibn55hAgm8pNUypg9U3DWOQL1iiB8j8hiTXcWeINTmXgR7WPSwpKKxpJW7+RUTvsFxU/jDNmvyb5Khp1vGzZHgRVUJXgeMmjc++79f8neqNZfZJ66J0kc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778120233; c=relaxed/simple; bh=kHnjARW+TF9xfZP6oEbxt59KWoJQlz0Bd+tOaK3roWQ=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=oMFtoSp+rr5BQHIMsi9f9QPPbaTAIgx8vzV+3X2REZwSD1zPCJYmLb2eoxBse8nLhum2OFSkXaNNQgAsfELPeuV6Jp3OlFlPgaOt9tqVbyDYPPFDjKSJETjD1Ofe2yGuBIGxhuCi3rKz0C4qbx+lvK39v6BhWhH3jaboSXLwD1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fLl0lVYl; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fLl0lVYl" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2addb31945aso2582675ad.1 for ; Wed, 06 May 2026 19:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778120231; x=1778725031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=QfljaX0j/OnEAlVF44pPhl2QZFR+lhq0RxifLBR+ro0=; b=fLl0lVYlcFY6vvTbAA8rIAbpbIkSvcp8SHwbnXS9zd0IMPC7IxtzvC4LHjPslm26b2 RORiqaVfLSM0luXE1XxK4VdOAg5OpBx1ptM2cMnIuoS2X8LBQYyPqfeiB9RZRMyQvb9m vxfm5qDSYivb5Xp/PHoH6wR84drqiEUw02LaYXNp62rzvLZ1xpQvbUOPCtJLSmfI7H3H 3v1zWvSLb6t/IUsddTR5oUUK3WUaeHEK46OootmoACyrK1tbMzlAvvTvzWyr8SYCb26d OHpt4pEAQ52BqPjuIzYOx1ElJW9xcTU1X+ew+rQ5Rf72zRuwklAQJB9fLJvXbJKwHRh3 qvHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778120231; x=1778725031; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QfljaX0j/OnEAlVF44pPhl2QZFR+lhq0RxifLBR+ro0=; b=m4wOY39gE8WOdTyKlnFoX9WXmbnL9eSrJdFpqXNkjioA1PgZXhVb20k/QGDSwwLhuC w/psl1RB9etBLf+v9lu+6xnbAu8rwAkY5zkAqp79WSsHEoibOd7OHrvkj0E3h3xiiyu0 oM7ZcTICUAG7AXaAOgmqn6ZxxRFQoZvGQsLG57KdsMTgk00sn4llQXJQQKpaybVP0hE9 RvO+aHw5K0sOft/SR6HhweyYDaetjHc9J5sxFM0dZdTiiTsEzMpASaURZz3KKGuVsh1c 5QyN+1oaw/FLLp2u4t4OZO5BiQJc+NzoeFyJ0gmVb+lgqVG+PK97OL+3fiIiHAApVrgF 9Rvg== X-Forwarded-Encrypted: i=1; AFNElJ8H2Dyj0BUiipcPiThnvsh7+/6LNnY7tl/OBlge7f5/wMSqFJOMuFQS6Xou+SImj4TDgIASO0rgKjnO9a0=@vger.kernel.org X-Gm-Message-State: AOJu0YwaVNKEf8OwcAzsRzjLONA3en70AWDm+7EL0RbyjmpTHldAqi/m MwBl22Uq0eN7yvZHgECo1XcIhJwdTNAzPx23/62ZotWAxIYd1o7JxI3O X-Gm-Gg: AeBDiet+D4CTbheoizqx5SO4SKraiatFw7HV9NnzMD/qbXgc5OWH/YUo96p9BK3Mj0+ /ztywGOWAj3a6jLxNefkGAk8M68rT9zN546Ywni4u+zOshaAbGUT8us2BVhGL7rAZ+xvVKOfSoI 3vA/hBq8iwq7gQD3zoT5bHc9q+NQhMaDXEXeuywo+yl3+lBEsAiS/uN1BgeFzjCZUaUlvKhD3a+ Rzii1aqGb8/QRmCzSDDLzQsFuDFTi+rmpr8Kt6TPmVa2PcNA+QmhCS+N7fMTGf/pLYFxTpHLYmq 2YIAxrlPtI1szEXgRUz+EDkOn8zOwRIH10/sD7MDwrq9/221FqA9mj/MGFH+2vXQBh5xqDpHt2m iHMR50XcalVp6GbhGfbB2VhcG/9+/RUJuQdSeyGwmFyu6GXNm+BskZzBMPUQ02OsNLOzbMt4OL4 R8Vc5bojUsIF0soTYR7Gm4BfDh/xm5aPa9x38AwvT19Iy4EDvS/6ZG8+BvpA== X-Received: by 2002:a17:903:3850:b0:2ba:b738:bc2 with SMTP id d9443c01a7336-2bab7381ebdmr15578345ad.27.1778120230584; Wed, 06 May 2026 19:17:10 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:ac23:b594:789f:a6c4:c581:db80]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babaac3495sm6259255ad.13.2026.05.06.19.17.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 19:17:10 -0700 (PDT) Date: Thu, 07 May 2026 07:47:05 +0530 From: Sanjay Chitroda To: Joshua Crofts CC: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/10] iio: accel: mma8452: use local struct device User-Agent: Thunderbird for Android In-Reply-To: References: <20260505174640.3998281-1-sanjayembedded@gmail.com> <20260505174640.3998281-8-sanjayembedded@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 6 May 2026 2:49:33=E2=80=AFpm IST, Joshua Crofts wrote: >On Tue, 5 May 2026 at 19:50, Sanjay Chitroda wrote: >> @@ -1552,7 +1552,7 @@ static int mma8452_probe(struct i2c_client *clien= t) >> struct iio_dev *indio_dev; >> int ret; > >As mentioned, you added the local struct device in patch 5, making >this really confusing (and potentially breaking if only a partial set >of the patches would be picked up)=2E Please add it here=2E Hi Joshua, Thank you for the review=2E I have prepared series as there is some dependency on earlier change with = respect to current=2E If we pick random change it has high changes to fail= =2E FYI, compilation is validated on each change so if someone take few initia= l patch then hopefully nothing would break=2E Additionally, if we plan to t= ake random patches from series based on some review comment or requirement = then I would resend new series specific to that patches to avoid any break= =2E >