public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging/lustre: add BLOCK depends in Kconfig
@ 2013-07-25  7:06 Xiong Zhou
  2013-07-25 10:52 ` Paul Bolle
  2013-07-25 23:17 ` Dilger, Andreas
  0 siblings, 2 replies; 6+ messages in thread
From: Xiong Zhou @ 2013-07-25  7:06 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Andreas Dilger, Jiri Kosina, linux-kernel, Peng Tao, devel,
	jencce.kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 807 bytes --]

From: Xiong Zhou <jencce.kernel@gmail.com>

Add BLOCK depends in Kconfig for LUSTRE to fix this:
drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2: 
error: implicit declaration of function ‘unregister_blkdev’ 

Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
---
 drivers/staging/lustre/lustre/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
index 9ae7fa8..0b45de0 100644
--- a/drivers/staging/lustre/lustre/Kconfig
+++ b/drivers/staging/lustre/lustre/Kconfig
@@ -1,6 +1,6 @@
 config LUSTRE_FS
 	tristate "Lustre file system client support"
-	depends on STAGING && INET && m
+	depends on STAGING && INET && BLOCK && m
 	select LNET
 	select CRYPTO
 	select CRYPTO_CRC32

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig
  2013-07-25  7:06 [PATCH] staging/lustre: add BLOCK depends in Kconfig Xiong Zhou
@ 2013-07-25 10:52 ` Paul Bolle
  2013-07-26  6:03   ` Xiong Zhou
  2013-07-25 23:17 ` Dilger, Andreas
  1 sibling, 1 reply; 6+ messages in thread
From: Paul Bolle @ 2013-07-25 10:52 UTC (permalink / raw)
  To: Xiong Zhou
  Cc: Greg Kroah-Hartman, Andreas Dilger, Jiri Kosina, linux-kernel,
	Peng Tao, devel

On Thu, 2013-07-25 at 15:06 +0800, Xiong Zhou wrote:
> Add BLOCK depends in Kconfig for LUSTRE to fix this:
> drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2: 
> error: implicit declaration of function ‘unregister_blkdev’ 
> 
> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
> ---
>  drivers/staging/lustre/lustre/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
> index 9ae7fa8..0b45de0 100644
> --- a/drivers/staging/lustre/lustre/Kconfig
> +++ b/drivers/staging/lustre/lustre/Kconfig
> @@ -1,6 +1,6 @@
>  config LUSTRE_FS
>         tristate "Lustre file system client support"
> -       depends on STAGING && INET && m
> +       depends on STAGING && INET && BLOCK && m

Everything below drivers/staging/lustre/Kconfig is only sourced if
STAGING is set. You can drop the dependency on STAGING.

>         select LNET
>         select CRYPTO
>         select CRYPTO_CRC32


Paul Bolle


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig
  2013-07-25  7:06 [PATCH] staging/lustre: add BLOCK depends in Kconfig Xiong Zhou
  2013-07-25 10:52 ` Paul Bolle
@ 2013-07-25 23:17 ` Dilger, Andreas
  2013-07-26  6:54   ` Xiong Zhou
  1 sibling, 1 reply; 6+ messages in thread
From: Dilger, Andreas @ 2013-07-25 23:17 UTC (permalink / raw)
  To: Xiong Zhou, Peng Tao
  Cc: Jiri Kosina, linux-kernel@vger.kernel.org, Greg Kroah-Hartman

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1560 bytes --]

On 2013/07/25 1:06 AM, "Xiong Zhou" <jencce.kernel@gmail.com> wrote:

>From: Xiong Zhou <jencce.kernel@gmail.com>
>
>Add BLOCK depends in Kconfig for LUSTRE to fix this:
>drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2
>: 
>error: implicit declaration of function ʽunregister_blkdevʼ
>
>Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
>---
> drivers/staging/lustre/lustre/Kconfig |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/staging/lustre/lustre/Kconfig
>b/drivers/staging/lustre/lustre/Kconfig
>index 9ae7fa8..0b45de0 100644
>--- a/drivers/staging/lustre/lustre/Kconfig
>+++ b/drivers/staging/lustre/lustre/Kconfig
>@@ -1,6 +1,6 @@
> config LUSTRE_FS
> 	tristate "Lustre file system client support"
>-	depends on STAGING && INET && m
>+	depends on STAGING && INET && BLOCK && m
> 	select LNET
> 	select CRYPTO
> 	select CRYPTO_CRC32

The Lustre client does not need a block device - it is a network
filesystem.
The one piece of code that is relevant here relates to a Lustre-optimized
"loop" device that bypasses the VFS, data copying, and DLM locking for use
by swap and such.  It would be better instead to make that code conditional
and add a new CONFIG_LUSTRE_LLOOP or similar, and only make that part
dependent
on BLOCK.

Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig
  2013-07-25 10:52 ` Paul Bolle
@ 2013-07-26  6:03   ` Xiong Zhou
  0 siblings, 0 replies; 6+ messages in thread
From: Xiong Zhou @ 2013-07-26  6:03 UTC (permalink / raw)
  To: Paul Bolle
  Cc: Greg Kroah-Hartman, Andreas Dilger, Jiri Kosina,
	linux-kernel@vger.kernel.org, Peng Tao, devel

2013/7/25 Paul Bolle <pebolle@tiscali.nl>:
> On Thu, 2013-07-25 at 15:06 +0800, Xiong Zhou wrote:
>> Add BLOCK depends in Kconfig for LUSTRE to fix this:
>> drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2:
>> error: implicit declaration of function ‘unregister_blkdev’
>>
>> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
>> ---
>>  drivers/staging/lustre/lustre/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
>> index 9ae7fa8..0b45de0 100644
>> --- a/drivers/staging/lustre/lustre/Kconfig
>> +++ b/drivers/staging/lustre/lustre/Kconfig
>> @@ -1,6 +1,6 @@
>>  config LUSTRE_FS
>>         tristate "Lustre file system client support"
>> -       depends on STAGING && INET && m
>> +       depends on STAGING && INET && BLOCK && m
>
> Everything below drivers/staging/lustre/Kconfig is only sourced if
> STAGING is set. You can drop the dependency on STAGING.
>

Yes, it is. Thanks~

>>         select LNET
>>         select CRYPTO
>>         select CRYPTO_CRC32
>
>
> Paul Bolle
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig
  2013-07-25 23:17 ` Dilger, Andreas
@ 2013-07-26  6:54   ` Xiong Zhou
  2013-07-26  7:34     ` Dilger, Andreas
  0 siblings, 1 reply; 6+ messages in thread
From: Xiong Zhou @ 2013-07-26  6:54 UTC (permalink / raw)
  To: Dilger, Andreas
  Cc: Peng Tao, Jiri Kosina, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman

2013/7/26 Dilger, Andreas <andreas.dilger@intel.com>:
> On 2013/07/25 1:06 AM, "Xiong Zhou" <jencce.kernel@gmail.com> wrote:
>
>>From: Xiong Zhou <jencce.kernel@gmail.com>
>>
>>Add BLOCK depends in Kconfig for LUSTRE to fix this:
>>drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2
>>:
>>error: implicit declaration of function ʽunregister_blkdevʼ
>>
>>Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
>>---
>> drivers/staging/lustre/lustre/Kconfig |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/drivers/staging/lustre/lustre/Kconfig
>>b/drivers/staging/lustre/lustre/Kconfig
>>index 9ae7fa8..0b45de0 100644
>>--- a/drivers/staging/lustre/lustre/Kconfig
>>+++ b/drivers/staging/lustre/lustre/Kconfig
>>@@ -1,6 +1,6 @@
>> config LUSTRE_FS
>>       tristate "Lustre file system client support"
>>-      depends on STAGING && INET && m
>>+      depends on STAGING && INET && BLOCK && m
>>       select LNET
>>       select CRYPTO
>>       select CRYPTO_CRC32
>
> The Lustre client does not need a block device - it is a network
> filesystem.
> The one piece of code that is relevant here relates to a Lustre-optimized
> "loop" device that bypasses the VFS, data copying, and DLM locking for use
> by swap and such.  It would be better instead to make that code conditional
> and add a new CONFIG_LUSTRE_LLOOP or similar, and only make that part
> dependent
> on BLOCK.
>
> Cheers, Andreas
> --
> Andreas Dilger
>

This makes sence. I noticed that this patch has gone into Greg's tree,
so a coming patch
based on this patch is cool?

> Lustre Software Architect
> Intel High Performance Data Division
>
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig
  2013-07-26  6:54   ` Xiong Zhou
@ 2013-07-26  7:34     ` Dilger, Andreas
  0 siblings, 0 replies; 6+ messages in thread
From: Dilger, Andreas @ 2013-07-26  7:34 UTC (permalink / raw)
  To: Xiong Zhou
  Cc: Peng Tao, Jiri Kosina, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1954 bytes --]

On 2013/07/26 12:54 AM, "Xiong Zhou" <jencce.kernel@gmail.com> wrote:

>2013/7/26 Dilger, Andreas <andreas.dilger@intel.com>:
>> On 2013/07/25 1:06 AM, "Xiong Zhou" <jencce.kernel@gmail.com> wrote:
>>
>>>From: Xiong Zhou <jencce.kernel@gmail.com>
>>>
>>>Add BLOCK depends in Kconfig for LUSTRE to fix this:
>>>drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117
>>>:2
>>>:
>>>error: implicit declaration of function ʽunregister_blkdevʼ
>>>
>>>Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
>>>---
>>> drivers/staging/lustre/lustre/Kconfig |    2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/drivers/staging/lustre/lustre/Kconfig
>>>b/drivers/staging/lustre/lustre/Kconfig
>>>index 9ae7fa8..0b45de0 100644
>>>--- a/drivers/staging/lustre/lustre/Kconfig
>>>+++ b/drivers/staging/lustre/lustre/Kconfig
>>>@@ -1,6 +1,6 @@
>>> config LUSTRE_FS
>>>       tristate "Lustre file system client support"
>>>-      depends on STAGING && INET && m
>>>+      depends on STAGING && INET && BLOCK && m
>>>       select LNET
>>>       select CRYPTO
>>>       select CRYPTO_CRC32
>>
>> The Lustre client does not need a block device - it is a network
>> filesystem.
>> The one piece of code that is relevant here relates to a
>>Lustre-optimized
>> "loop" device that bypasses the VFS, data copying, and DLM locking for
>>use
>> by swap and such.  It would be better instead to make that code
>>conditional
>> and add a new CONFIG_LUSTRE_LLOOP or similar, and only make that part
>> dependent on BLOCK.
>
>This makes sence. I noticed that this patch has gone into Greg's tree,
>so a coming patch based on this patch is cool?

That would be fine, thanks.

Cheers, Andreas
-- 
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division


ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-26  7:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-25  7:06 [PATCH] staging/lustre: add BLOCK depends in Kconfig Xiong Zhou
2013-07-25 10:52 ` Paul Bolle
2013-07-26  6:03   ` Xiong Zhou
2013-07-25 23:17 ` Dilger, Andreas
2013-07-26  6:54   ` Xiong Zhou
2013-07-26  7:34     ` Dilger, Andreas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox