From: "Bollinger, Seth" <Seth.Bollinger@digi.com>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>
Subject: Re: Possible software flow problem in serial_core
Date: Fri, 21 Mar 2014 00:48:14 +0000 [thread overview]
Message-ID: <CF50F620.6EC5%seth.bollinger@digi.com> (raw)
In-Reply-To: <532B891E.80705@hurleysoftware.com>
>Yeah, you're right; thanks for catching this.
>(I was busy looking at the ll driver and completely missed the bug in
>the serial core).
>
>uart_start() should not be conditioning the call to start_tx() on
>the ring buffer being empty; ll drivers should already be able to handle
>that because CTS flow control change will start_tx regardless of the ring
>buffer count.
>
>Will you send a patch?
Sure thing. Just to be clear, you want to remove the ring buffer tests
and leave the tty tests, right?
This will have to wait for the morning though. :)
Seth
next prev parent reply other threads:[~2014-03-21 0:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 13:44 Possible software flow problem in serial_core Bollinger, Seth
2014-03-20 23:05 ` Peter Hurley
2014-03-20 23:34 ` Bollinger, Seth
2014-03-21 0:34 ` Peter Hurley
2014-03-21 0:48 ` Bollinger, Seth [this message]
2014-03-21 1:07 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF50F620.6EC5%seth.bollinger@digi.com \
--to=seth.bollinger@digi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox