From: Thorsten Blum <thorsten.blum@linux.dev>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Miroslav Benes <mbenes@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Re-add resume_play_dead() to noreturn list
Date: Mon, 27 Oct 2025 22:33:01 +0100 [thread overview]
Message-ID: <CF8E694D-D8ED-417F-967F-E83E34E6CBB7@linux.dev> (raw)
In-Reply-To: <rpvygldy2s2ybabzsoylbitpn5o7w6vustbox4jd22pwznydwe@6v36xs6vxo64>
On 27. Oct 2025, at 21:37, Josh Poimboeuf wrote:
> Hm? There's no "resume_play_dead" in the diff for 6245ce4ab670.
>
> That was actually done intentionally with a different commit:
>
> 34245659debd ("objtool: Remove superfluous global_noreturns entries")
Sorry, I must have missed this. Please drop this patch then.
It's a bit unfortunate that this is neither documented in
objtool/noreturns.h, where it rather misleadingly says "all functions":
/*
* This is a (sorted!) list of all known __noreturn functions in the kernel.
* ...
*/
nor in objtool/Documentation/objtool.txt:
"A noreturn function must be marked __noreturn in both its declaration
and its definition, and must have a NORETURN() annotation in
tools/objtool/noreturns.h."
Only the __dead_end_function() function comment in objtool/check.c and
the implementation itself make this clear.
Thanks,
Thorsten
prev parent reply other threads:[~2025-10-27 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 16:39 [PATCH] objtool: Re-add resume_play_dead() to noreturn list Thorsten Blum
2025-10-27 20:37 ` Josh Poimboeuf
2025-10-27 21:33 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CF8E694D-D8ED-417F-967F-E83E34E6CBB7@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox