Re: [PATCH v2 RESEND 08/23] hpsa: Fallback to MSI rather than to INTx if MSI-X failed

Alexander Gordeev
2014-08-13T16:58:44Z

On Wed, Aug 13, 2014 at 11:04:54AM -0500, scameron@beardog.cce.hp.com wrote:
> On Wed, Jul 16, 2014 at 08:05:12PM +0200, Alexander Gordeev wrote:
> > Currently the driver falls back to INTx mode when MSI-X
> > initialization failed. This is a suboptimal behaviour
> > for chips that also support MSI. This update changes that
> > behaviour and falls back to MSI mode in case MSI-X mode
> > initialization failed.
> >
> > Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> > Cc: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>
> > Cc: iss_storagedev@hp.com
> > Cc: linux-scsi@vger.kernel.org
> > Cc: linux-pci@vger.kernel.org
> > ---
> > drivers/scsi/hpsa.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> > index 31184b3..648dec2 100644
> > --- a/drivers/scsi/hpsa.c
> > +++ b/drivers/scsi/hpsa.c
> > @@ -6177,7 +6177,6 @@ static void hpsa_interrupt_mode(struct ctlr_info *h)
> > dev_warn(&h->pdev->dev, "MSI-X init failed %d\n",
> > err);
> > h->msix_vector = 0;
> > - goto default_int_mode;
> > }
> > }
> > if (pci_find_capability(h->pdev, PCI_CAP_ID_MSI)) {
> > --
> > 1.7.7.6
>
> Ack.
>
> Sorry for the slow reply, this got lost in the tornadic maelstrom
> I call my inbox.
>
> I also tested this with a Smart Array P420, P420i, and P430 in
> the system by ifdef'ing out the code for MSI-X and setting
> h->msix_vector = 0, to force it down the MSI path, and that all
> appears to work.

Thank you, Steve!
If your Ack apply to 08/23 or to 09/23 as well?

> -- steve
>

--
Regards,
Alexander Gordeev
agordeev@redhat.com