Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed

Tomas Henzl
2014-07-29T13:49:11Z

On 07/29/2014 03:20 PM, Christoph Hellwig wrote:
> On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote:
>> Hi,
>> patch looks good.
>>
>> A correction in pm8001_request_irq might be added too to allow
>> the INT-X path when pm8001_setup_msix fails, but that is not part
>> of this fix.
>
> There's actually an equivalent fix already in through one of the
> previous pm8001 updates, so I skipped this one even if it already had an
> ACK. The following pm8001 applied just fine, though. Take a look, as
> I've already pushed out the updated drivers branch.

I'm a bit confused - you were not commenting my text above I think?

I see in drivers-for-3.17 this patch already applied 5607de7
but not yet the next one (18/23) which also has a review, is there another ack needed?

>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html