RE: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

Jayamohan Kallickal
2014-07-28T23:30:25Z

-----Original Message-----
From: Alexander Gordeev [mailto:agordeev@redhat.com]
Sent: Saturday, July 26, 2014 1:09 AM
To: linux-kernel@vger.kernel.org; Jayamohan Kallickal
Subject: Re: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix()

On Wed, Jul 16, 2014 at 08:05:05PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers using these
> two interfaces need to be updated to use the new
> pci_enable_msi_range() or pci_enable_msi_exact() and
> pci_enable_msix_range() or pci_enable_msix_exact() interfaces.

Hi Jayamohan,

Could you please review this patch?

Thanks!

> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
> drivers/scsi/be2iscsi/be_main.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c
> b/drivers/scsi/be2iscsi/be_main.c index 56467df..1f63169 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -5278,12 +5278,10 @@ static void beiscsi_msix_enable(struct beiscsi_hba *phba)
> for (i = 0; i <= phba->num_cpus; i++)
> phba->msix_entries[i].entry = i;
>
> - status = pci_enable_msix(phba->pcidev, phba->msix_entries,
> - (phba->num_cpus + 1));
> + status = pci_enable_msix_exact(phba->pcidev, phba->msix_entries,
> + phba->num_cpus + 1);
> if (!status)
> phba->msix_enabled = true;
> -
> - return;
> }
>
> static void be_eqd_update(struct beiscsi_hba *phba)
> --
> 1.7.7.6
>

Looks Good.

Acked-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
--