Re: [PATCH v2 RESEND 22/23] qla4xxx: Use pci_enable_msix_exact() instead of pci_enable_msix()

Vikas Chaudhary
2014-07-28T11:47:27Z

Acked-By: Vikas Chaudhary <vikas.chaudhary@qlogic.com>

On 26/07/14 2:11 pm, "Alexander Gordeev" <agordeev@redhat.com> wrote:

>On Wed, Jul 16, 2014 at 08:05:26PM +0200, Alexander Gordeev wrote:
>> As result of deprecation of MSI-X/MSI enablement functions
>> pci_enable_msix() and pci_enable_msi_block() all drivers
>> using these two interfaces need to be updated to use the
>> new pci_enable_msi_range() or pci_enable_msi_exact()
>> and pci_enable_msix_range() or pci_enable_msix_exact()
>> interfaces.
>
>Hi Vikas,
>
>Could you please reveiw this patch?
>
>Thanks!
>
>> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
>> Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
>> Cc: iscsi-driver@qlogic.com
>> Cc: linux-scsi@vger.kernel.org
>> Cc: linux-pci@vger.kernel.org
>> Acked-By: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
>> ---
>> drivers/scsi/qla4xxx/ql4_nx.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/scsi/qla4xxx/ql4_nx.c
>>b/drivers/scsi/qla4xxx/ql4_nx.c
>> index 9dbdb4b..7c33658 100644
>> --- a/drivers/scsi/qla4xxx/ql4_nx.c
>> +++ b/drivers/scsi/qla4xxx/ql4_nx.c
>> @@ -4221,7 +4221,7 @@ qla4_8xxx_enable_msix(struct scsi_qla_host *ha)
>> for (i = 0; i < QLA_MSIX_ENTRIES; i++)
>> entries[i].entry = qla4_8xxx_msix_entries[i].entry;
>>
>> - ret = pci_enable_msix(ha->pdev, entries, ARRAY_SIZE(entries));
>> + ret = pci_enable_msix_exact(ha->pdev, entries, ARRAY_SIZE(entries));
>> if (ret) {
>> ql4_printk(KERN_WARNING, ha,
>> "MSI-X: Failed to enable support -- %d/%d\n",
>> --
>> 1.7.7.6
>>
>
>--
>Regards,
>Alexander Gordeev
>agordeev@redhat.com