From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Loic Poulain" <loic.poulain@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>
Cc: <~postmarketos/upstreaming@lists.sr.ht>,
<phone-devel@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm6350: Add camera clock controller
Date: Tue, 24 Jan 2023 15:48:32 +0100 [thread overview]
Message-ID: <CQ0I4ONEI6J4.3KWS1KBE7RTKD@otso> (raw)
In-Reply-To: <e5ff49d4-45c7-8c4a-d624-d8f7cc9ce2cb@linaro.org>
On Fri Jan 20, 2023 at 5:49 PM CET, Bryan O'Donoghue wrote:
> On 20/01/2023 13:13, Luca Weiss wrote:
> > + camcc: clock-controller@ad00000 {
> > + compatible = "qcom,sm6350-camcc";
> > + reg = <0 0x0ad00000 0 0x16000>;
> > + clocks = <&rpmhcc RPMH_CXO_CLK>;
> > + #clock-cells = <1>;
> > + #reset-cells = <1>;
> > + #power-domain-cells = <1>;
> > + };
>
> Should you include
>
> required-opps = <&rpmhpd_opp_low_svs>;
>
> ?
I don't know, it works without. But doesn't this property not just
affect power-domains? I haven't passed any here.
>
> ---
> bod
next prev parent reply other threads:[~2023-01-24 14:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 13:13 [PATCH v2 0/4] Add CCI bus support for SM6350 Luca Weiss
2023-01-20 13:13 ` [PATCH v2 1/4] dt-bindings: i2c: qcom-cci: Document SM6350 compatible Luca Weiss
2023-01-23 22:12 ` Wolfram Sang
2023-01-20 13:13 ` [PATCH v2 2/4] arm64: dts: qcom: sm6350: Add camera clock controller Luca Weiss
2023-01-20 16:49 ` Bryan O'Donoghue
2023-01-24 14:48 ` Luca Weiss [this message]
2023-01-24 15:25 ` Bryan O'Donoghue
2023-01-27 12:45 ` Luca Weiss
2023-01-27 12:49 ` Bryan O'Donoghue
2023-01-27 13:11 ` Luca Weiss
2023-01-27 13:14 ` Konrad Dybcio
2023-01-27 13:54 ` Bryan O'Donoghue
2023-01-27 13:56 ` Konrad Dybcio
2023-01-20 13:13 ` [PATCH v2 3/4] arm64: dts: qcom: sm6350: Add CCI nodes Luca Weiss
2023-01-20 13:16 ` Konrad Dybcio
2023-01-20 13:13 ` [PATCH v2 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Enable CCI busses Luca Weiss
2023-02-09 4:23 ` (subset) [PATCH v2 0/4] Add CCI bus support for SM6350 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CQ0I4ONEI6J4.3KWS1KBE7RTKD@otso \
--to=luca.weiss@fairphone.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox