Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y

Masahiro Yamada
2023-11-22T03:09:48Z

On Tue, Nov 21, 2023 at 6:55 PM Aneesh Kumar K.V
<aneesh.kumar@kernel.org> wrote:
>
> "Nicholas Piggin" <npiggin@gmail.com> writes:
>
> > On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote:
> >> crtsavres.o is linked to modules. However, as explained in commit
> >> d0e628cd817f ("kbuild: doc: clarify the difference between extra-y
> >> and always-y"), 'make modules' does not build extra-y.
> >>
> >> For example, the following command fails:
> >>
> >> $ make ARCH=powerpc LLVM=1 KBUILD_MODPOST_WARN=1 mrproper ps3_defconfig modules
> >> [snip]
> >> LD [M] arch/powerpc/platforms/cell/spufs/spufs.ko
> >> ld.lld: error: cannot open arch/powerpc/lib/crtsavres.o: No such file or directory
> >> make[3]: *** [scripts/Makefile.modfinal:56: arch/powerpc/platforms/cell/spufs/spufs.ko] Error 1
> >> make[2]: *** [Makefile:1844: modules] Error 2
> >> make[1]: *** [/home/masahiro/workspace/linux-kbuild/Makefile:350: __build_one_by_one] Error 2
> >> make: *** [Makefile:234: __sub-make] Error 2
> >>
> >
> > Thanks. Is this the correct Fixes tag?
> >
> > Fixes: d0e628cd817f ("powerpc/64: Do not link crtsavres.o in vmlinux")
> >
>
> I am finding a different commit ID:
>
> commit baa25b571a168aff5a13bfdc973f1229e2b12b63
> Author: Nicholas Piggin <npiggin@gmail.com>
> Date: Fri May 12 01:56:49 2017 +1000
>
> powerpc/64: Do not link crtsavres.o in vmlinux
>
> The 64-bit linker creates save/restore functions on demand with final
> links, so vmlinux does not require crtsavres.o.
>
>
> -aneesh

Yeah, I think the correct tag is:

Fixes: baa25b571a16 ("powerpc/64: Do not link crtsavres.o in vmlinux")

--
Best Regards
Masahiro Yamada