Re: [PATCH v3 04/17] dt-bindings: soc: mobileye: add EyeQ5 OLB system controller

Krzysztof Kozlowski
2024-01-26T14:55:03Z

On 26/01/2024 13:28, Théo Lebrun wrote:
>>>
>>> pinctrl0: pinctrl-a {
>>> compatible = "mobileye,eyeq5-a-pinctrl";
>>> reg = <0x0B0 0x30>;
>>> };
>>>
>>> pinctrl1: pinctrl-b {
>>> compatible = "mobileye,eyeq5-b-pinctrl";
>>> reg = <0x0B0 0x30>;
>>
>> Duplicate reg?
>
> Yes, the mapping is intertwined. Else it could be three ressources per
> pinctrl. Just really small ones.
>
> - 0xB0 mapping A
> - 0xB4 mapping B
> - 0xB8
> - 0xBC
> - 0xC0 pull-down A
> - 0xC4 pull-up A
> - 0xC8 pull-down B
> - 0xCC pull-up B
> - 0xD0 drive-strength lo A
> - 0xD4 drive-strength hi A
> - 0xD8 drive-strength lo B
> - 0xDC drive-strength hi B
>
> 0xB8 is unrelated (I2C speed & SPI CS). 0xBC is a hole.

Then maybe Rob's idea of one pinctrl device is better...

Best regards,
Krzysztof