From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Alexander Gordeev" <agordeev@linux.ibm.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-s390@vger.kernel.org>,
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/5] sched/vtime: remove confusing arch_vtime_task_switch() declaration
Date: Fri, 09 Feb 2024 13:28:17 +1000 [thread overview]
Message-ID: <CZ089ERGIDWI.14PQB4HD4F1NH@wheely> (raw)
In-Reply-To: <f5c88d9290bca3b280cfdd499c236a3c390af51b.1707422448.git.agordeev@linux.ibm.com>
On Fri Feb 9, 2024 at 6:15 AM AEST, Alexander Gordeev wrote:
> Callback arch_vtime_task_switch() is only defined when
> CONFIG_VIRT_CPU_ACCOUNTING_NATIVE is selected. Yet, the
> function prototype forward declaration is present for
> CONFIG_VIRT_CPU_ACCOUNTING_GEN variant. Remove it.
>
And powerpc arch_vtime_task_switch is static inline too,
so this just confuses things.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
> Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
> include/linux/vtime.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/vtime.h b/include/linux/vtime.h
> index 3684487d01e1..593466ceebed 100644
> --- a/include/linux/vtime.h
> +++ b/include/linux/vtime.h
> @@ -18,7 +18,6 @@ extern void vtime_account_idle(struct task_struct *tsk);
> #endif /* !CONFIG_VIRT_CPU_ACCOUNTING */
>
> #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
> -extern void arch_vtime_task_switch(struct task_struct *tsk);
> extern void vtime_user_enter(struct task_struct *tsk);
> extern void vtime_user_exit(struct task_struct *tsk);
> extern void vtime_guest_enter(struct task_struct *tsk);
next prev parent reply other threads:[~2024-02-09 3:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 20:15 [PATCH v2 0/5] sched/vtime: vtime.h headers cleanup Alexander Gordeev
2024-02-08 20:15 ` [PATCH v2 1/5] sched/vtime: remove confusing arch_vtime_task_switch() declaration Alexander Gordeev
2024-02-09 3:28 ` Nicholas Piggin [this message]
2024-02-08 20:15 ` [PATCH v2 2/5] sched/vtime: get rid of generic vtime_task_switch() implementation Alexander Gordeev
2024-02-09 3:36 ` Nicholas Piggin
2024-02-08 20:15 ` [PATCH v2 3/5] s390/vtime: remove unused __ARCH_HAS_VTIME_TASK_SWITCH leftover Alexander Gordeev
2024-02-09 3:36 ` Nicholas Piggin
2024-02-08 20:15 ` [PATCH v2 4/5] s390/irq,nmi: include <asm/vtime.h> header directly Alexander Gordeev
2024-02-08 20:15 ` [PATCH v2 5/5] sched/vtime: do not include <asm/vtime.h> header Alexander Gordeev
2024-02-09 3:38 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZ089ERGIDWI.14PQB4HD4F1NH@wheely \
--to=npiggin@gmail.com \
--cc=agordeev@linux.ibm.com \
--cc=frederic@kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox