From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BFB73C498; Mon, 19 Feb 2024 14:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708354512; cv=none; b=jNapdEJcLoe8HZ56BttbMPzHLq9r7l4VlHE+dSrvNZ8nR1vSU4otUH05p6ErdHP7t2I/qA/bD3qzAegAK+j4DfEZNZ4may4UG8e8S4lY8V9lTn8DoHxYkS6W2Xl3wMiLvOeckI7jN4Fg6ft4CskbcAbDAdUt9k4x8UAUeW0XlFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708354512; c=relaxed/simple; bh=HfxplOuL4q2xzVZw2TcJFzzqRvoMGhVC0FGr2EalnFk=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=Unf5x23o891Jexzu68TLpUPK0XbPbeWWieGcndx0BSckvgMA2Nom//TXXLGKtNBaHuJcfwZvV1ZDEPP1Jt4GA0Hf1Uks35Fxi5IKTEoYa67sx87jH23YwpMC4UXi4PEp/2uIrjIJY8O9PEXLB9kcIuRPNtYwIeV9Jjs2HTdK8pU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=DQrOLR+8; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="DQrOLR+8" Received: by mail.gandi.net (Postfix) with ESMTPSA id 010D64000D; Mon, 19 Feb 2024 14:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1708354507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lC1i1N0UNT/0y8QCJSxQOgeE4oJ6ZMsxZMZkpa3P++M=; b=DQrOLR+8qm0bY5slL6AB6BEDjk5hcfQb6M/P+U/Yz4hAszxWqXlg7zof7bpVXHb6qdKWTw 6pfod3Ipext1BnHghowE0GYoMePMiFejmBxRovogdYzKujHPwRJTvaYD4GiMPuznwvlM5d pMcNd+J3Wioq1qwLUEzVT7jK2i3EnL+7NCruF52BF1DyUMdPAcVo5Qcq0QI5DjLxMEEvKN BEfpk6D7byjJwG/neMbHlQIBSnc4srjB+vBb4puI2KRovGSUl7jQL0gw+WP+C9GOxUJTmS 7Goniy3e24fzWP/GB2WPy1IT4jvkCxPUgtgtXZGZTXn/TH1g9AW4/UbqdWVcdg== Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Feb 2024 15:55:06 +0100 Message-Id: Subject: Re: [PATCH 02/23] dt-bindings: gpio: nomadik: add optional ngpios property Cc: "Bartosz Golaszewski" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Philipp Zabel" , "Thomas Bogendoerfer" , , , , , , "Gregory CLEMENT" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Linus Walleij" From: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: aerc 0.15.2 References: <20240214-mbly-gpio-v1-0-f88c0ccf372b@bootlin.com> <20240214-mbly-gpio-v1-2-f88c0ccf372b@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Mon Feb 19, 2024 at 3:50 PM CET, Linus Walleij wrote: > On Wed, Feb 14, 2024 at 5:24=E2=80=AFPM Th=C3=A9o Lebrun wrote: > > > This GPIO controller can support a lesser number of GPIOs than 32. > > Express that in devicetree using an optional, generic property. > > > > Signed-off-by: Th=C3=A9o Lebrun > > --- > > Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yam= l b/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml > > index a999908173d2..bbd23daed229 100644 > > --- a/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml > > +++ b/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml > > @@ -50,6 +50,10 @@ properties: > > gpio-ranges: > > maxItems: 1 > > > > + ngpios: > > + minimum: 0 > > + maximum: 32 > > I can't help but wonder what good is ngpios =3D <0>; but OK. > Reviewed-by: Linus Walleij A min value is required, else it is equal to the max. There was no reason to pick anything bigger than zero. I'll admit it is not a setup I have tested so the driver might have issues with the ngpios=3D=3D0 edge-case. Of course I do not expect anyone to care. Regards, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com