Re: [PATCH 03/23] dt-bindings: gpio: nomadik: add mobileye,eyeq5-gpio compatible

Krzysztof Kozlowski
2024-02-15T09:13:15Z

On 14/02/2024 17:23, Théo Lebrun wrote:
> This GPIO controller is used on the Mobileye EyeQ5 SoC. Add its
> compatible to the dt-bindings. One difference is that the block as
> integrated on EyeQ5 does not support sleep-mode.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> .../devicetree/bindings/gpio/st,nomadik-gpio.yaml | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml b/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml
> index bbd23daed229..e44cf292bc6d 100644
> --- a/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/st,nomadik-gpio.yaml
> @@ -19,7 +19,9 @@ properties:
> pattern: "^gpio@[0-9a-f]+$"
>
> compatible:
> - const: st,nomadik-gpio
> + enum:
> + - st,nomadik-gpio
> + - mobileye,eyeq5-gpio
>
> reg:
> maxItems: 1
> @@ -65,6 +67,18 @@ required:
>
> unevaluatedProperties: false
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: st,nomadik-gpio
> + then:
> + properties:
> + st,supports-sleepmode:
> + description: Whether the controller can sleep or not.
> + $ref: /schemas/types.yaml#/definitions/flag

You already have such property, so you are defining it second time. You
want instead if: for eyeq5-gpio making it:
then:
properties:
st,supports-sleepmode: false

Best regards,
Krzysztof