Re: [PATCH v6 09/13] pinctrl: eyeq5: add platform driver

Théo Lebrun
2024-02-21T18:24:06Z

Hello,

On Wed Feb 21, 2024 at 2:41 PM CET, Linus Walleij wrote:
> On Mon, Feb 12, 2024 at 2:44 PM Théo Lebrun <theo.lebrun@bootlin.com> wrote:
>
> > Add the Mobileye EyeQ5 pin controller driver. It might grow to add later
> > support of other platforms from Mobileye. It belongs to a syscon region
> > called OLB.
> >
> > Existing pins and their function live statically in the driver code
> > rather than in the devicetree, see compatible match data.
> >
> > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> > + ret = devm_pinctrl_register_and_init(dev, &pctrl->desc, pctrl, &pctldev);
> > + if (ret) {
> > + dev_err(dev, "Failed registering pinctrl device: %d\n", ret);
> > + return ret;
> > + }
> > +
> > + ret = pinctrl_enable(pctldev);
> > + if (ret) {
> > + dev_err(dev, "Failed enabling pinctrl device: %d\n", ret);
> > + return ret;
> > + }
>
> You could use dev_err_probe() here which suppresses -EPROBE_DEFER
> messages, but I'm not picky, just mentioning it.

Well, I've followed your suggestion in the v7 revision. Thanks!

https://lore.kernel.org/lkml/20240221-mbly-clk-v7-0-31d4ce3630c3@bootlin.com/

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering