Re: Re: [PATCH v9 15/15] selftests/sgx: Add scripts for EPC cgroup testing

Haitao Huang
2024-04-02T18:20:29Z

On Tue, 02 Apr 2024 12:40:03 -0500, Michal Koutný <mkoutny@suse.com> wrote:

> On Tue, Apr 02, 2024 at 11:20:21AM -0500, Haitao Huang
> <haitao.huang@linux.intel.com> wrote:
>> Do we really want to have it implemented in c?
>
> I only pointed to the available C boilerplate.
>
>> There are much fewer lines of
>> code in shell scripts. Note we are not really testing basic cgroup
>> stuff.
>> All we needed were creating/deleting cgroups and set limits which I
>> think
>> have been demonstrated feasible in the ash scripts now.
>
> I assume you refer to
> Message-Id: <20240331174442.51019-1-haitao.huang@linux.intel.com>
> right?
>
> Could it be even simpler if you didn't stick to cgtools APIs and v1
> compatibility?
>
> Reducing ash_cgexec.sh to something like
> echo 0 >$R/$1/cgroup.procs
> shift
> exec "$@"
> (with some small builerplate for $R and previous mkdirs)
>
Yes, Thanks for the suggestion.
Haitao