Re: [RFC PATCH] x86/sgx: Remove 'reclaim' boolean parameters

Jarkko Sakkinen
2024-02-19T20:23:29Z

On Mon Feb 19, 2024 at 3:39 PM UTC, Haitao Huang wrote:
> Remove all boolean parameters for 'reclaim' from the function
> sgx_alloc_epc_page() and its callers by making two versions of each
> function.
>
> Also opportunistically remove non-static declaration of
> __sgx_alloc_epc_page() and a typo
>
> Signed-off-by: Haitao Huang <haitao.huang@linux.intel.com>
> Suggested-by: Jarkko Sakkinen <jarkko@kernel.org>

I think this is for better.

My view point for kernel patches overally is that:

1. A feature should leave the subsystem in cleaner state as
far as the existing framework of doing things goes.
2. A bugfix can sometimes do the opposite if corner case
requires some weird dance to perform.

BR, Jarkko