From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>,
"Stefan Berger" <stefanb@linux.ibm.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>
Cc: <keyrings@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <saulo.alessandre@tse.jus.br>,
<bbhushan2@marvell.com>
Subject: Re: [PATCH v6 00/13] Add support for NIST P521 to ecdsa
Date: Tue, 19 Mar 2024 20:25:04 +0200 [thread overview]
Message-ID: <CZXXRA9PVPXI.2X41IISN77CUV@kernel.org> (raw)
In-Reply-To: <CZXXPKTAUUM9.35VZUFITJWF6A@kernel.org>
On Tue Mar 19, 2024 at 8:22 PM EET, Jarkko Sakkinen wrote:
> On Tue Mar 19, 2024 at 12:42 AM EET, Stefan Berger wrote:
> >
> >
> > On 3/18/24 14:48, Lukas Wunner wrote:
> > > On Tue, Mar 12, 2024 at 02:36:05PM -0400, Stefan Berger wrote:
> > >> This series adds support for the NIST P521 curve to the ecdsa module
> > >> to enable signature verification with it.
> > >
> > > v6 of this series is still
> > >
> > > Tested-by: Lukas Wunner <lukas@wunner.de>
> >
> > Thanks.
>
> This has been discussed before in LKML but generally tested-by for
> series does not have semantical meaning.
>
> Please apply only for patches that were tested.
How to implement this in practice or place tested-by correctly?
I'd place the tested-by to the patch which contains the uapi trigger
to which for testing was done.
By having this granularity that also does help fixing bugs later on
so it is really not just "plain bureacracy".
BR, Jarkko
next prev parent reply other threads:[~2024-03-19 18:25 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 18:36 [PATCH v6 00/13] Add support for NIST P521 to ecdsa Stefan Berger
2024-03-12 18:36 ` [PATCH v6 01/13] crypto: ecc - Use ECC_CURVE_NIST_P192/256/384_DIGITS where possible Stefan Berger
2024-03-18 20:08 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 02/13] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-03-18 20:21 ` Jarkko Sakkinen
2024-03-18 20:35 ` Lukas Wunner
2024-03-18 22:20 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 03/13] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-03-18 20:25 ` Jarkko Sakkinen
2024-03-18 20:32 ` Lukas Wunner
2024-03-18 22:25 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 04/13] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-03-18 20:33 ` Jarkko Sakkinen
2024-03-18 20:39 ` Lukas Wunner
2024-03-18 22:19 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 05/13] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-03-18 20:34 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 06/13] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-03-18 5:47 ` [EXTERNAL] " Bharat Bhushan
2024-03-18 18:38 ` Stefan Berger
2024-03-19 3:53 ` Bharat Bhushan
2024-03-18 20:35 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 07/13] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-03-18 20:50 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 08/13] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-03-18 21:05 ` Jarkko Sakkinen
2024-03-18 22:54 ` Stefan Berger
2024-03-12 18:36 ` [PATCH v6 09/13] crypto: ecdsa - Replace ndigits with nbits where precision is needed Stefan Berger
2024-03-18 21:06 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 10/13] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-03-18 21:07 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 11/13] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-03-18 21:08 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 12/13] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-03-18 5:58 ` [EXTERNAL] " Bharat Bhushan
2024-03-18 7:06 ` Lukas Wunner
2024-03-19 3:38 ` Bharat Bhushan
2024-03-18 21:12 ` Jarkko Sakkinen
2024-03-18 22:42 ` Stefan Berger
2024-03-19 18:21 ` Jarkko Sakkinen
2024-03-12 18:36 ` [PATCH v6 13/13] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
2024-03-15 17:10 ` [PATCH v6 00/13] Add support for NIST P521 to ecdsa Stefan Berger
2024-03-18 18:48 ` Lukas Wunner
2024-03-18 22:42 ` Stefan Berger
2024-03-19 18:22 ` Jarkko Sakkinen
2024-03-19 18:25 ` Jarkko Sakkinen [this message]
2024-03-19 18:55 ` Stefan Berger
2024-03-19 19:14 ` Jarkko Sakkinen
2024-03-20 5:40 ` Lukas Wunner
2024-03-20 14:41 ` Konstantin Ryabitsev
2024-03-21 16:17 ` Jarkko Sakkinen
2024-03-21 16:19 ` Jarkko Sakkinen
2024-03-21 16:36 ` Stefan Berger
2024-03-21 16:50 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZXXRA9PVPXI.2X41IISN77CUV@kernel.org \
--to=jarkko@kernel.org \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=saulo.alessandre@tse.jus.br \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox