From: "Thierry Reding" <thierry.reding@gmail.com>
To: "Akhil R" <akhilrajeev@nvidia.com>, <ldewangan@nvidia.com>,
<jonathanh@nvidia.com>, <vkoul@kernel.org>,
<dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 RESEND] dmaengine: tegra186: Fix residual calculation
Date: Mon, 25 Mar 2024 14:30:10 +0100 [thread overview]
Message-ID: <D02V8R59Y6I3.13XIQDA5L6QCK@gmail.com> (raw)
In-Reply-To: <20240315124411.17582-1-akhilrajeev@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On Fri Mar 15, 2024 at 1:44 PM CET, Akhil R wrote:
> The existing residual calculation returns an incorrect value when
> bytes_xfer == bytes_req. This scenario occurs particularly with drivers
> like UART where DMA is scheduled for maximum number of bytes and is
> terminated when the bytes inflow stops. At higher baud rates, it could
> request the tx_status while there is no bytes left to transfer. This will
> lead to incorrect residual being set. Hence return residual as '0' when
> bytes transferred equals to the bytes requested.
>
> Fixes: ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> v1->v2:
> * corrected typo - s/exisiting/existing/
>
> drivers/dma/tegra186-gpc-dma.c | 3 +++
> 1 file changed, 3 insertions(+)
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-03-25 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 12:44 [PATCH v2 RESEND] dmaengine: tegra186: Fix residual calculation Akhil R
2024-03-25 13:30 ` Thierry Reding [this message]
2024-03-28 7:39 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D02V8R59Y6I3.13XIQDA5L6QCK@gmail.com \
--to=thierry.reding@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox