Re: [PATCH 01/11] dt-bindings: soc: mobileye: add EyeQ5 OLB system controller

Stephen Boyd
2024-04-11T03:29:21Z

Quoting Théo Lebrun (2024-04-10 10:12:30)
> diff --git a/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml
> new file mode 100644
> index 000000000000..c4e33a167fab
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/mobileye/mobileye,eyeq5-olb.yaml
> @@ -0,0 +1,125 @@
[..]
> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 1
> +
> + ranges: true
> +
> +patternProperties:
> + '^clock-controller@[0-9a-f]+$':
> + $ref: /schemas/clock/mobileye,eyeq5-clk.yaml#
> +
> + '^reset-controller@[0-9a-f]+$':
> + $ref: /schemas/reset/mobileye,eyeq5-reset.yaml#
> +
> + '^pinctrl@[0-9a-f]+$':
> + $ref: /schemas/pinctrl/mobileye,eyeq5-pinctrl.yaml#

Yep, there shouldn't be subnodes for these. Instead, olb should have
#clock-cells, #reset-cells, etc. and the driver registers auxiliary
devices for each driver like the clk driver, reset driver, pinctrl
driver. Then we don't need syscon or simple-mfd and random other drivers
can't use the regmap.