Re: [PATCH 03/11] dt-bindings: reset: mobileye,eyeq5-reset: add EyeQ6L and EyeQ6H

Krzysztof Kozlowski
2024-04-11T06:14:45Z

On 10/04/2024 19:12, Théo Lebrun wrote:
> Add bindings for EyeQ6L and EyeQ6H reset controllers.
>
> Some controllers host a single domain, meaning a single cell is enough.
> We do not enforce reg-names for such nodes.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> .../bindings/reset/mobileye,eyeq5-reset.yaml | 88 ++++++++++++++++++----
> MAINTAINERS | 1 +
> 2 files changed, 74 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/mobileye,eyeq5-reset.yaml b/Documentation/devicetree/bindings/reset/mobileye,eyeq5-reset.yaml
> index 062b4518347b..799bcf15bed9 100644
> --- a/Documentation/devicetree/bindings/reset/mobileye,eyeq5-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/mobileye,eyeq5-reset.yaml
> @@ -4,11 +4,13 @@
> $id: http://devicetree.org/schemas/reset/mobileye,eyeq5-reset.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Mobileye EyeQ5 reset controller
> +title: Mobileye EyeQ reset controller
>
> description:
> - The EyeQ5 reset driver handles three reset domains. Its registers live in a
> - shared region called OLB.
> + EyeQ reset controller handles one or more reset domains. They live in shared
> + regions called OLB. EyeQ5 and EyeQ6L host one OLB each, each with one reset
> + instance. EyeQ6H hosts 7 OLB regions; three of those (west, east,
> + accelerator) host reset controllers. West and east are duplicates.
>
> maintainers:
> - Grégory Clement <gregory.clement@bootlin.com>
> @@ -17,27 +19,83 @@ maintainers:
>
> properties:
> compatible:
> - const: mobileye,eyeq5-reset
> + enum:
> + - mobileye,eyeq5-reset
> + - mobileye,eyeq6l-reset
> + - mobileye,eyeq6h-we-reset
> + - mobileye,eyeq6h-acc-reset
>
> - reg:
> - maxItems: 3
> + reg: true

Same mistakes. Please open existing bindings with multiple variants,
e.g. some Qualcomm, and take a look how it is done there.

Best regards,
Krzysztof