Re: [PATCH v12 14/14] selftests/sgx: Add scripts for EPC cgroup testing

Haitao Huang
2024-04-16T22:21:39Z

On Tue, 16 Apr 2024 17:04:21 -0500, Haitao Huang
<haitao.huang@linux.intel.com> wrote:

> On Tue, 16 Apr 2024 11:08:11 -0500, Jarkko Sakkinen <jarkko@kernel.org>
> wrote:
>
>> On Tue Apr 16, 2024 at 5:54 PM EEST, Haitao Huang wrote:
>>> I did declare the configs in the config file but I missed it in my
>>> patch
>>> as stated earlier. IIUC, that would not cause this error though.
>>>
>>> Maybe I should exit with the skip code if no CGROUP_MISC (no more
>>> CGROUP_SGX_EPC) is configured?
>>
>> OK, so I wanted to do a distro kernel test here, and used the default
>> OpenSUSE kernel config. I need to check if it has CGROUP_MISC set.
>>
>>> tools/testing/selftests$ find . -name README
>>> ./futex/README
>>> ./tc-testing/README
>>> ./net/forwarding/README
>>> ./powerpc/nx-gzip/README
>>> ./ftrace/README
>>> ./arm64/signal/README
>>> ./arm64/fp/README
>>> ./arm64/README
>>> ./zram/README
>>> ./livepatch/README
>>> ./resctrl/README
>>
>> So is there a README because of override timeout parameter? Maybe it
>> should be just set to a high enough value?
>>
>> BR, Jarkko
>>
>
>
> From the docs, I think we are supposed to use override.
> See:
> https://docs.kernel.org/dev-tools/kselftest.html#timeout-for-selftests
>
> Thanks
> Haitao
>

Maybe you are suggesting we add settings file? I can do that.
README also explains what the tests do though. Do you still think they
should not exist?
I was mostly following resctrl as example.

Thanks
Haitao