From: "Dilger, Andreas" <andreas.dilger@intel.com>
To: Maxime Lorrillere <maxime.lorrillere@lip6.fr>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"laure.millet@lip6.fr" <laure.millet@lip6.fr>
Subject: Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit
Date: Wed, 18 Mar 2015 19:53:35 +0000 [thread overview]
Message-ID: <D12F33AE.E6D1A%andreas.dilger@intel.com> (raw)
In-Reply-To: <1426705646-11943-1-git-send-email-maxime.lorrillere@lip6.fr>
On 2015/03/18, 1:07 PM, "Maxime Lorrillere" <maxime.lorrillere@lip6.fr>
wrote:
>From: Laure Millet <laure.millet@lip6.fr>
>
>This patch fixes lines over 80 characters
I think the newer rule is that strings shouldn't be split across lines.
That makes
the first hunk invalid, though the second one is OK.
Cheers, Andreas
>Signed-off-by: Laure Millet <laure.millet@lip6.fr>
>Signed-off-by: Maxime Lorrillere <maxime.lorrillere@lip6.fr>
>---
> drivers/staging/lustre/lustre/llite/namei.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/llite/namei.c
>b/drivers/staging/lustre/lustre/llite/namei.c
>index 3fa529d..49f1cb0 100644
>--- a/drivers/staging/lustre/lustre/llite/namei.c
>+++ b/drivers/staging/lustre/lustre/llite/namei.c
>@@ -83,7 +83,8 @@ static int ll_set_inode(struct inode *inode, void
>*opaque)
>
> lli->lli_fid = body->fid1;
> if (unlikely(!(body->valid & OBD_MD_FLTYPE))) {
>- CERROR("Can not initialize inode " DFID " without object type: valid =
>%#llx\n",
>+ CERROR("Can not initialize inode " DFID
>+ " without object type: valid = %#llx\n",
> PFID(&lli->lli_fid), body->valid);
> return -EINVAL;
> }
>@@ -600,7 +601,8 @@ static int ll_atomic_open(struct inode *dir, struct
>dentry *dentry,
> long long lookup_flags = LOOKUP_OPEN;
> int rc = 0;
>
>- CDEBUG(D_VFSTRACE, "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags
>%x,mode %x opened %d\n",
>+ CDEBUG(D_VFSTRACE,
>+ "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags %x,mode %x
>opened %d\n",
> dentry, dir->i_ino,
> dir->i_generation, dir, file, open_flags, mode, *opened);
>
>--
>1.7.10.4
>
>
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
next prev parent reply other threads:[~2015-03-18 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 19:07 [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit Maxime Lorrillere
2015-03-18 19:53 ` Dilger, Andreas [this message]
2015-03-18 20:30 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D12F33AE.E6D1A%andreas.dilger@intel.com \
--to=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=laure.millet@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.lorrillere@lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox