From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756808AbbCRTxk (ORCPT ); Wed, 18 Mar 2015 15:53:40 -0400 Received: from mga03.intel.com ([134.134.136.65]:7965 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756131AbbCRTxi convert rfc822-to-8bit (ORCPT ); Wed, 18 Mar 2015 15:53:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,423,1422950400"; d="scan'208";a="469111027" From: "Dilger, Andreas" To: Maxime Lorrillere , "gregkh@linuxfoundation.org" CC: "linux-kernel@vger.kernel.org" , "laure.millet@lip6.fr" Subject: Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit Thread-Topic: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit Thread-Index: AQHQYa7N+hJo8xBhbU+6EBc4IB/XGJ0it+2A Date: Wed, 18 Mar 2015 19:53:35 +0000 Message-ID: References: <1426705646-11943-1-git-send-email-maxime.lorrillere@lip6.fr> In-Reply-To: <1426705646-11943-1-git-send-email-maxime.lorrillere@lip6.fr> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.75.195] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/03/18, 1:07 PM, "Maxime Lorrillere" wrote: >From: Laure Millet > >This patch fixes lines over 80 characters I think the newer rule is that strings shouldn't be split across lines. That makes the first hunk invalid, though the second one is OK. Cheers, Andreas >Signed-off-by: Laure Millet >Signed-off-by: Maxime Lorrillere >--- > drivers/staging/lustre/lustre/llite/namei.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/drivers/staging/lustre/lustre/llite/namei.c >b/drivers/staging/lustre/lustre/llite/namei.c >index 3fa529d..49f1cb0 100644 >--- a/drivers/staging/lustre/lustre/llite/namei.c >+++ b/drivers/staging/lustre/lustre/llite/namei.c >@@ -83,7 +83,8 @@ static int ll_set_inode(struct inode *inode, void >*opaque) > > lli->lli_fid = body->fid1; > if (unlikely(!(body->valid & OBD_MD_FLTYPE))) { >- CERROR("Can not initialize inode " DFID " without object type: valid = >%#llx\n", >+ CERROR("Can not initialize inode " DFID >+ " without object type: valid = %#llx\n", > PFID(&lli->lli_fid), body->valid); > return -EINVAL; > } >@@ -600,7 +601,8 @@ static int ll_atomic_open(struct inode *dir, struct >dentry *dentry, > long long lookup_flags = LOOKUP_OPEN; > int rc = 0; > >- CDEBUG(D_VFSTRACE, "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags >%x,mode %x opened %d\n", >+ CDEBUG(D_VFSTRACE, >+ "VFS Op:name=%pd,dir=%lu/%u(%p),file %p,open_flags %x,mode %x >opened %d\n", > dentry, dir->i_ino, > dir->i_generation, dir, file, open_flags, mode, *opened); > >-- >1.7.10.4 > > Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division